Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update External Dependency: Pako - #19474

Merged
zoracon merged 3 commits into
EFForg:masterfrom
zoracon:update-external-dependencies
Aug 13, 2020
Merged

zoracon merged 3 commits into
EFForg:masterfrom
zoracon:update-external-dependencies

Conversation

@zoracon

@zoracon zoracon commented Aug 12, 2020

Copy link
Copy Markdown
Contributor

This is an attempt to monitor this dependency in a way that can catch any vulnerabilities with this version of Pako in case it needs to be updated.

If, for some reason this is not a good approach for a historical reason I am missing, please let me know. This not something I am particularly pushing if there is a good reason why I shouldn't. My thinking here is that our automated security flows will catch an issue before I personally can and provide an automated PR I can review.

@zoracon
zoracon requested a review from Hainish August 12, 2020 20:42
@zoracon zoracon self-assigned this Aug 12, 2020
@cschanaj

cschanaj commented Aug 13, 2020 •

Copy link
Copy Markdown
Collaborator

I remember that the version of the dependencies to the extension is hard-coded to maintain a deterministic build. See discussions in #13560 . I agree it would be a good idea to update the dependencies once a while in order to get ride of the security flows.

@zoracon

zoracon commented Aug 13, 2020

Copy link
Copy Markdown
Contributor Author

@cschanaj This makes sense. I think I will just simply add Pako and CodeMirror to package.json to be able to be monitor security issues within our flow with these versions. And keep the what is there in the external directory for now until it needs to be updated as needed by an alert.

Listing the externals we are using through their NPM equivalent to be
caught by automated security vulnerability scans
@zoracon
zoracon merged commit 508163c into EFForg:master Aug 13, 2020
@zoracon
zoracon deleted the update-external-dependencies branch August 13, 2020 17:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants