This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
Update External Dependency: Pako - #19474
Merged
Merged
Conversation
Collaborator
|
I remember that the version of the dependencies to the extension is hard-coded to maintain a deterministic build. See discussions in #13560 . I agree it would be a good idea to update the dependencies once a while in order to get ride of the security flows. |
Contributor
Author
|
@cschanaj This makes sense. I think I will just simply add Pako and CodeMirror to package.json to be able to be monitor security issues within our flow with these versions. And keep the what is there in the external directory for now until it needs to be updated as needed by an alert. |
Listing the externals we are using through their NPM equivalent to be caught by automated security vulnerability scans
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to monitor this dependency in a way that can catch any vulnerabilities with this version of Pako in case it needs to be updated.
If, for some reason this is not a good approach for a historical reason I am missing, please let me know. This not something I am particularly pushing if there is a good reason why I shouldn't. My thinking here is that our automated security flows will catch an issue before I personally can and provide an automated PR I can review.