Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Fix styles when display language is not English, issue #18482 - #18495

Merged
zoracon merged 2 commits into
EFForg:masterfrom
cschanaj:fix-style-18482
Oct 30, 2019
Merged

zoracon merged 2 commits into
EFForg:masterfrom
cschanaj:fix-style-18482

Conversation

@cschanaj

@cschanaj cschanaj commented Oct 6, 2019

Copy link
Copy Markdown
Collaborator

This PR fixes the UI distortion when the display language is not English

List related issues if any

@cschanaj
cschanaj marked this pull request as ready for review October 6, 2019 07:37
@pipboy96 pipboy96 added the ui label Oct 6, 2019
@cschanaj
cschanaj requested a review from zoracon October 6, 2019 23:42
@@ -76,7 +76,6 @@ footer a.button {

/* Elements */
.settings_block {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing a display issue with this branch where the grey horizontal line is now crossing the "see more" text with English. Going to see if this can be amended for both by aligning display: block with padding.
image

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added additional padding to to make the "See more" element align better in ea8ee20

@cschanaj
cschanaj requested a review from zoracon October 9, 2019 03:42
@cschanaj

Copy link
Copy Markdown
Collaborator Author

@zoracon would you take a look at the fix and merge this possibly before the next release?

@zoracon zoracon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zoracon
zoracon merged commit d63b5a1 into EFForg:master Oct 30, 2019
@cschanaj
cschanaj deleted the fix-style-18482 branch October 30, 2019 21:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants