Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Make it possible to open debugging ruleset editor on Firefox - #17352

Closed
pipboy96 wants to merge 4 commits into
EFForg:masterfrom
pipboy96:patch-31
Closed

pipboy96 wants to merge 4 commits into
EFForg:masterfrom
pipboy96:patch-31

Conversation

@pipboy96

@pipboy96 pipboy96 commented Feb 1, 2019 •

Copy link
Copy Markdown
Contributor

On latest Firefox Nightly, pressing Ctrl-Z on options page does nothing if you are viewing it from Firefox UI, and if you are viewing it directly it just shows a "popup blocked" message.

@pipboy96

pipboy96 commented Feb 2, 2019

Copy link
Copy Markdown
Contributor Author

screenshot

@Hainish

Hainish commented Jun 5, 2019

Copy link
Copy Markdown
Member

I'm not a fan of exposing this to users. This functionality was added specifically for maintainers to make it easier to test rulesets. Creating an additional route to add custom rulesets adds UX complexity, and will cause people to rely on this even if we add a warning to it.

Popups are probably not blocked intentionally for extensions in Firefox, I'm wondering if this is a regression we can open a bug report for in bugzilla..

@pipboy96

pipboy96 commented Jun 5, 2019

Copy link
Copy Markdown
Contributor Author

@Hainish There is already a bug open, it seems to be stalled.

BTW can we simply remove this UI and ask people who want to use it to directly type the URL for the editor if you want it to be hidden? Just make sure to document it for devs to be able to use it.

@pipboy96

pipboy96 commented Jun 5, 2019

Copy link
Copy Markdown
Contributor Author

https://bugzilla.mozilla.org/show_bug.cgi?id=1429624

Last activity 9 months ago, no follow-up.

@pipboy96

pipboy96 commented Jun 5, 2019 •

Copy link
Copy Markdown
Contributor Author

wait, can we make Ctrl + Z make this link visible and set a "developer mode" flag in extension storage?

@Hainish

@Hainish

Hainish commented Jun 6, 2019

Copy link
Copy Markdown
Member

@pipboy96 yes, that makes sense. I'd merge that.

@pipboy96

pipboy96 commented Jun 6, 2019

Copy link
Copy Markdown
Contributor Author

@Hainish Ok, I close this and start work on this suggestion.

@pipboy96 pipboy96 closed this Jun 6, 2019
@pipboy96
pipboy96 deleted the patch-31 branch June 6, 2019 00:20
@pipboy96
pipboy96 restored the patch-31 branch June 6, 2019 12:56
@pipboy96
pipboy96 deleted the patch-31 branch June 6, 2019 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants