Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Run hsts-prune and fix impacted rulesets - #17102

Merged
J0WI merged 8 commits into
EFForg:masterfrom
Bisaloo:hsts
Dec 19, 2018
Merged

J0WI merged 8 commits into
EFForg:masterfrom
Bisaloo:hsts

Conversation

@Bisaloo

@Bisaloo Bisaloo commented Dec 1, 2018

Copy link
Copy Markdown
Collaborator

No description provided.

@Hainish Hainish added the top-100 label Dec 1, 2018
<ruleset name="Despora.de">

<target host="despora.de" />
<target host="www.despora.de" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This target is not yet preloaded (only ^ is).

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because only the main domain is listed, right? Like the others.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The host is not preloaded with the includeSubDomains flag in Firefox. Also, the server uses an invalid HSTS configuration: https://hstspreload.org/?domain=despora.de
So this host should be removed at all (#13682).

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, it's not surprising the script got confused here. I opened an issue to fix this issue directly with the website: despora/diaspora#12.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bisaloo could you revert the removal of Despora.de.xml for now that we can ship this in #17157?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@J0WI, done

Comment thread src/chrome/content/rules/G5.gov.xml Resolved
@J0WI
J0WI merged commit 54bba5d into EFForg:master Dec 19, 2018
@Bisaloo
Bisaloo deleted the hsts branch December 19, 2018 12:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants