Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Add ruleset for Aarhus University. - #16972

Merged
J0WI merged 3 commits into
EFForg:masterfrom
kimsey0:AarhusUniversitet
Oct 28, 2018
Merged

J0WI merged 3 commits into
EFForg:masterfrom
kimsey0:AarhusUniversitet

Conversation

@kimsey0

@kimsey0 kimsey0 commented Oct 22, 2018

Copy link
Copy Markdown
Contributor

Aarhus University in Denmark. In top 10k on Alexa.

Domains found using Sublist3r, automatically filtered to remove for example domains with invalid certificates, then manually reviewed.

@kimsey0

kimsey0 commented Oct 23, 2018 •

Copy link
Copy Markdown
Contributor Author

@Hainish: Shouldn't this be labelled top-10k instead, or do you use another ranking?

@Hainish Hainish closed this Oct 25, 2018
@Hainish Hainish reopened this Oct 25, 2018
@Hainish

Hainish commented Oct 25, 2018

Copy link
Copy Markdown
Member

@kimsey0 we might be using a slightly outdated ranking list. Looks like it's moving up in popularity.

@kimsey0

kimsey0 commented Oct 28, 2018

Copy link
Copy Markdown
Contributor Author

@Hainish, @J0WI: fetch.sh fails for applemdm.auit.au.dk, vipomat.hum.au.dk, maillist.au.dk and vc.au.dk because of certificate errors.

applemdm.auit.au.dk doesn't actually seem to have a valid certificate, so I'll remove that one, but the other three have valid certificates signed by Thawte (intermediate Thawte RSA CA 2018, root DigiCert Global Root CA), Let's Encrypt (intermediate Let's Encrypt Authority X3, root ISRG Root X1) and Thawte, respectively.

The intermediate certificates seem to have been issued after the last time the certificate store for https_everywhere_checker was updated (#6790). Should I reopen #6569 or open a new issue about this?

@J0WI

J0WI commented Oct 28, 2018

Copy link
Copy Markdown
Contributor

@kimsey0 our testsuite seems to be correct:

$  curl https://vipomat.hum.au.dk
curl: (60) SSL certificate problem: unable to get local issuer certificate

@kimsey0

kimsey0 commented Oct 28, 2018

Copy link
Copy Markdown
Contributor Author

@J0WI: I'm also not able to get cURL to accept the certificates, but try in a browser - it works there.

Should I just remove these domain from the ruleset? Both maillist.au.dk and vc.au.dk contain login forms, so I'd prefer not to.

@J0WI

J0WI commented Oct 28, 2018

Copy link
Copy Markdown
Contributor

Firefox caches intermediate certs. $ firefox --profile $(mktemp -d) --new-instance https://vipomat.hum.au.dk does also fail.

We use comments to document non-functional hosts:
https://github.com/EFForg/https-everywhere/blob/master/CONTRIBUTING.md#non-working-hosts

@kimsey0

kimsey0 commented Oct 28, 2018 •

Copy link
Copy Markdown
Contributor Author

Caching doesn't seem to be the problem. Firefox on Windows successfully loads the site for me with a new profile, as does Chrome, Internet Explorer and Edge. Chrome on Android loads it successfully. Lynx on Ubuntu complains about the certificate just like cURL, even after a sudo update-ca-certificates.

According to SSL Labs, the certificate chains for vipomat.hum.au.dk, maillist.aau.dk and vc.au.dk are incomplete, which probably explains it. I'll disable the domains for now and contact au.dk to have them fix it.

Comment thread src/chrome/content/rules/Au.dk.xml Resolved
@kimsey0

kimsey0 commented Oct 28, 2018 •

Copy link
Copy Markdown
Contributor Author

Failing test seems to be an unrelated Chrome issue.

@J0WI

J0WI commented Oct 28, 2018

Copy link
Copy Markdown
Contributor

Let's just reopen to try again.

@J0WI J0WI closed this Oct 28, 2018
@J0WI J0WI reopened this Oct 28, 2018
@J0WI
J0WI merged commit a3e2d9d into EFForg:master Oct 28, 2018
@J0WI

J0WI commented Oct 28, 2018

Copy link
Copy Markdown
Contributor

All tests passed, thanks!

@kimsey0

kimsey0 commented Oct 28, 2018

Copy link
Copy Markdown
Contributor Author

Thank you!

@kimsey0
kimsey0 deleted the AarhusUniversitet branch October 28, 2018 19:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants