Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Use SHA256 in make.sh - #15206

Merged
Hainish merged 3 commits into
masterfrom
unknown repository
May 18, 2018
Merged

Hainish merged 3 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Apr 21, 2018

Copy link
Copy Markdown

No description provided.

@J0WI

J0WI commented May 15, 2018

Copy link
Copy Markdown
Contributor

openssl dgst -sha256 should be used for better x-platform compatibility.
@Hainish do we need this hash somewhere?

@J0WI J0WI added the toolchain label May 15, 2018
@Hainish

Hainish commented May 18, 2018

Copy link
Copy Markdown
Member

@J0WI This is mainly is used for manually checking cross-platform reproducibility, as well as reproducibility upon subsequent runs in the same platform.

@Hainish Hainish left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you instead do openssl dgst -sha256 -binary "$cwd/$zip" | xxd -p? This nicely formats the output.

@ghost

ghost commented May 18, 2018

Copy link
Copy Markdown
Author

@Hainish Done.

@Hainish
Hainish merged commit 6134b7b into EFForg:master May 18, 2018
@ghost
ghost deleted the use-sha256 branch May 18, 2018 20:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants