This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
Sign rulesets - #15063
Merged
Merged
Sign rulesets#15063
Conversation
…s, and the new way rulesets are loaded
previously be able to switch `default.rulesets.gz` with an old signed ruleset file. We now combine the fact that the JavaScript checks that `latest-rulesets-timestamp` has a greater value than what is currently stored *and*, vitally, that it matches the timestamp bundled with the signed ruleset file.
cschanaj
reviewed
Apr 3, 2018
|
|
||
| // how often we should check for new rulesets | ||
| const periodicity = 10; | ||
| const periodicity = 7200; |
Collaborator
There was a problem hiding this comment.
@Hainish isn't this just 2 hours instead of 2 days in seconds?
Member
Author
There was a problem hiding this comment.
You're definitely right! Thank you.
Member
Author
There was a problem hiding this comment.
It's those little bugs which are killers. Glad you caught that.
Member
Author
|
This has been available for review and reviewed by a few people now. I'll be merging this tomorrow morning, and making a release in the afternoon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.