Repository navigation
[AmazonAWS.com] Add exclusion (fix #4510) - #14913
Conversation
|
I'm not able to reproduce #4510, maybe @gloomy-ghost or @jeremyn can? |
|
I can't verify it because I don't have flash installed, sorry |
|
I've followed some of the links in the original issue but I'm still not sure what this PR is fixing, in the sense of, what behavior changes on some site before and after including this fix. |
|
The video here was not playing because of MCB. Now it does. |
|
I'm having a difficult time testing this fix with the Because of the problem in issue #14927 I can't test the full ruleset directly in the debugging tool in Chrome, so I'm reducing the ruleset to something like this: <ruleset name="Test-AmazonWebServices">
<target host="*.amazonaws.com" />
<!-- The following subdomains have active mixed content which prevent videos from properly loading and playing.
Browsers do not display any MCB warning because those subdomains are just resources on pages such as
http://up.anv.bz/latest/anvload.html?key=eyJtIjoiY2JzIiwicCI6ImRlZmF1bHQiLCJ2IjoiMzM4NTA0MSIsInBsdWdpbnMiOnsiY29tc2NvcmUiOnsiY2xpZW50SWQiOiIzMDAwMDIzIiwiYzMiOiJuZXd5b3JrLmNic2xvY2FsLmNvbSJ9LCJkZnAiOnsiY2xpZW50U2lkZSI6eyJhZFRhZ1VybCI6Imh0dHA6Ly9wdWJhZHMuZy5kb3VibGVjbGljay5uZXQvZ2FtcGFkL2Fkcz9zej0yeDImaXU9LzQxMjgvQ0JTLk5ZJmNpdV9zenMmaW1wbD1zJmdkZnBfcmVxPTEmZW52PXZwJm91dHB1dD14bWxfdmFzdDImdW52aWV3ZWRfcG9zaXRpb25fc3RhcnQ9MSZ1cmw9W3JlZmVycmVyX3VybF0mZGVzY3JpcHRpb25fdXJsPVtkZXNjcmlwdGlvbl91cmxdJmNvcnJlbGF0b3I9W3RpbWVzdGFtcF0iLCJrZXlWYWx1ZXMiOnsiY2F0ZWdvcmllcyI6IltbQ0FURUdPUklFU11dIiwicHJvZ3JhbSI6IltbUFJPR1JBTV9OQU1FXV0iLCJzaXRlU2VjdGlvbiI6ImZlYXR1cmVkIn19fSwiaGVhcnRiZWF0QmV0YSI6eyJhY2NvdW50IjoiY2JzbG9jYWwtZ2xvYmFsLXVuaWZpZWQsY2JzbG9jYWwtc3RhdGlvbi1uZXd5b3JrLW5ld3lvcmstdW5pZmllZCxjYnNsb2NhbC1zdWJwcmltYXJ5LXN3dHYtdW5pZmllZCxjYnNsb2NhbC1tYXJrZXQtbmV3eW9yay11bmlmaWVkIiwicHVibGlzaGVySWQiOiI4MjNCQTAzMzU1Njc0OTdGN0YwMDAxMDFAQWRvYmVPcmciLCJqb2JJZCI6InNjX3ZhIiwibWFya2V0aW5nQ2xvdWRJZCI6IjgyM0JBMDMzNTU2NzQ5N0Y3RjAwMDEwMUBBZG9iZU9yZyIsInRyYWNraW5nU2VydmVyIjoiY2JzZGlnaXRhbG1lZGlhLmhiLm9tdHJkYy5uZXQiLCJjdXN0b21UcmFja2luZ1NlcnZlciI6ImNic2RpZ2l0YWxtZWRpYS5kMS5zYy5vbXRyZGMubmV0IiwidmVyc2lvbiI6IjEuNSJ9LCJyZWFsVGltZUFuYWx5dGljcyI6dHJ1ZX0sImFudmFjayI6ImFudmF0b19jYnNsb2NhbF9hcHBfd2ViX3Byb2RfNTQ3ZjNlNDkyNDFlZjBlNWQzMGM3OWIyZWZiY2E1ZDkyYzY5OGY2NyJ9
-->
<exclusion pattern="^http://cbslocal-download\.s3\.amazonaws\.com/" />
<exclusion pattern="^http://cbslocal-uploads\.s3\.amazonaws\.com/" />
<test url="http://cbslocal-download.s3.amazonaws.com/anv-videos/variant/3385041.m3u8?X-Anvato-Adst-Auth=5B8ylV9Psq0J8sqxUapXNqEnHBjhNhxFSnjkPmevzCz3xOzkNG9a82eWkHKNXYbH" />
<test url="http://cbslocal-download.s3.amazonaws.com/crossdomain.xml" />
<test url="http://cbslocal-uploads.s3.amazonaws.com/anv-pvw/3E5/12B/3E512B6C6EDE47D3BA90EE8065CFDFCE_pvw-M2.jpg" />
<rule from="^http://([\w-]+)\.s3(-ap-(?:nor|sou)theast-1|-(?:eu|us)-west-\d|-external-\d|-sa-east-1)?\.amazonaws\.com/"
to="https://$1.s3$2.amazonaws.com/" />
</ruleset>With the original, presumably broken ruleset With the reduced, presumably fixed ruleset So, as things are, I'm not ready to approve this PR, but I'm not sure what to suggest and I'm not assigning this to myself. It might be helpful to have another test URL where it's easier to see for sure that it works or doesn't when I switch between the rulesets. Also, there is a tab instead of a space in the text |
|
@jeremyn, both |
|
Is there any other URL, anywhere that you know of, that this PR fixes? We probably shouldn't add an |
|
No idea sorry, I was just working with the info from #4510. I'm not even sure where this URL comes from. |
|
@Hainish Could you please review this PR? For one reason or another (see above), none of the current maintainers are able to approve this. |
|
Thanks @jeremyn, I'll take a look tomorrow. |
|
@jeremyn I'm not seeing your test ruleset change anything for that link. I am still getting the "Please install the latest Adobe Flash Player Plugin to watch this content" text and banner in Chrome. |
|
@Hainish, yes you need flash to reproduce. This issue here is that ,even with flash, the video won't play because of MCB. |
|
Thanks! |
No description provided.