Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Report issue format bot code coverage - #14617

Merged
Hainish merged 1 commit into
EFForg:masterfrom
strugee:issue-bot-code-coverage
Feb 15, 2018
Merged

Hainish merged 1 commit into
EFForg:masterfrom
strugee:issue-bot-code-coverage

Conversation

@strugee

@strugee strugee commented Feb 13, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@strugee

strugee commented Feb 13, 2018

Copy link
Copy Markdown
Contributor Author

Ref #14616

@strugee
strugee force-pushed the issue-bot-code-coverage branch from 4277514 to 731efd0 Compare February 13, 2018 03:03
@strugee

strugee commented Feb 13, 2018

Copy link
Copy Markdown
Contributor Author

Merge conflicts fixed (I forgot to pull before I changed stuff).

@strugee

strugee commented Feb 13, 2018

Copy link
Copy Markdown
Contributor Author

Just to clarify what this does, this is what the end of npm test looks like now:

[...lots of Perjury output...]

When we require the module and we pass it a new ruleset with a domain
  it returns an array: OK
  the array has no problems: OK
When we require the module and we pass it a ruleset issue with a domain
  it returns an array: OK
  the array has no problems: OK

SUMMARY
        Broken:         0
        Successes:      137
        Failures:       0
--------------|----------|----------|----------|----------|----------------|
File          |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
--------------|----------|----------|----------|----------|----------------|
All files     |    85.71 |    66.67 |    88.89 |    85.71 |                |
 issueedit.js |    83.33 |    57.89 |       75 |    84.78 |... 29,52,79,81 |
 labeler.js   |    61.54 |    28.57 |       75 |     62.5 |... 23,24,35,37 |
 newissue.js  |    90.91 |    81.82 |      100 |    90.63 |       17,18,41 |
 parse.js     |      100 |      100 |      100 |      100 |                |
 validate.js  |      100 |      100 |      100 |      100 |                |
--------------|----------|----------|----------|----------|----------------|

With some nice coloring too (to show low/medium/high numbers) that doesn't show up on GitHub :-)

@strugee

strugee commented Feb 14, 2018

Copy link
Copy Markdown
Contributor Author

/cc @Hainish (do you want me to CC you on all issue bot PRs? I'm not sure what the best workflow is)

@strugee strugee mentioned this pull request Feb 15, 2018
5 of 16 tasks
@Hainish

Hainish commented Feb 15, 2018

Copy link
Copy Markdown
Member

@strugee yes, that would be helpful. Thanks.

@Hainish
Hainish merged commit de68e44 into EFForg:master Feb 15, 2018
@strugee

strugee commented Feb 15, 2018

Copy link
Copy Markdown
Contributor Author

Great. I'll continue to do so then. Thanks for merging!

@strugee
strugee deleted the issue-bot-code-coverage branch February 15, 2018 03:32
@strugee strugee mentioned this pull request Feb 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants