This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
Add upgrade-insecure-requests to responseHeaders in HTTP Nowhere Mode #14600
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0fa804f
Add upgrade-insecure-requests to responseHeaders in HTTP Nowhere Mode…
0d1f114
When extension is disabled, do nothing
1e06bf1
If CSP already existed, modify it insteads
e4b17e8
Exclude .onion requests from being upgraded
9541530
Return responseHeaders only if it is modified
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There may be a wild edge case here. In
https-everywhere/chromium/background.js
Lines 247 to 253 in 2808747
.onionURLs that do not have HTTPS in HTTP Nowhere mode. If a.onionURL serves only one page in HTTPS, and the rest are over HTTP, landing on that page with this logic will cause the client to make unreachable upgraded requests over HTTPS.As I said, it's a pretty far-fetched edge case (why would a
.onionsite have a TLS configuration like that?) but it is possible, and probably worth accounting for.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Since
.onionrequests are encrypted anyway, IMHO we shall exclude them from the HTTPS upgrades, see e4b17e8There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think requests to non-
.onionwebsites should still be upgraded if they were made from.onionwebsite.