Repository navigation
Fixing some dev dependency requirements for Debian 9 as well as Fedor… - #13686
Conversation
| if [ ! -f /var/lib/dbus/machine-id ]; then | ||
| $SUDO_SHIM sh -c 'dbus-uuidgen > /var/lib/dbus/machine-id' | ||
| fi | ||
| export PYCURL_SSL_LIBRARY=nss |
There was a problem hiding this comment.
nss used to be the default fedora libcurl library, no longer
There was a problem hiding this comment.
In that case, also consider removing the NSS cipherlist at
There was a problem hiding this comment.
We should update the OpenSSL ciphers as well, since they are currently pinned at those offered by Firefox 51.
There was a problem hiding this comment.
Probably a task for another day, though.
There was a problem hiding this comment.
We should also ensure that the macOS development environment doesn't use NSS. Though I'm unsure how well macOS is supported in general, and I was unable to test this.
There was a problem hiding this comment.
I added that _DEFAULT_CIPHERLIST_NSS line specifically when I was working on Fedora last year. It seems unlikely that macOS needs it. I understand wanting to test it, though.
There was a problem hiding this comment.
Note that this also doesn't solve all the problems with Fedora, I'm still running into errors when I try to run the test in docker. This should at least get Fedora systems to a point where the dependencies are installed, though.
| if [ "$1" != "--no-prompt" ]; then | ||
| echo | ||
| echo "Warning: Installing the development dependencies for HTTPS Everywhere" | ||
| echo "may alter your system, installing requrements both within the package" |
…a. Only prompt once at the beginning, with a warning. Fixes EFForg#13597
387cc5c to
64c0476
Compare
…a. Only prompt once at the beginning, with a warning. Fixes #13597