Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Fixing some dev dependency requirements for Debian 9 as well as Fedor… - #13686

Merged
Hainish merged 1 commit into
EFForg:masterfrom
Hainish:fix-install-dev-deps
Nov 21, 2017
Merged

Hainish merged 1 commit into
EFForg:masterfrom
Hainish:fix-install-dev-deps

Conversation

@Hainish

@Hainish Hainish commented Nov 21, 2017

Copy link
Copy Markdown
Member

…a. Only prompt once at the beginning, with a warning. Fixes #13597

if [ ! -f /var/lib/dbus/machine-id ]; then
$SUDO_SHIM sh -c 'dbus-uuidgen > /var/lib/dbus/machine-id'
fi
export PYCURL_SSL_LIBRARY=nss

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nss used to be the default fedora libcurl library, no longer

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, also consider removing the NSS cipherlist at

# NSS cipher list from https://github.com/EFForg/https-everywhere/issues/5628#issuecomment-236050924
_DEFAULT_CIPHERLIST_NSS = "rsa_3des_sha,rsa_des_sha,rsa_null_md5,rsa_null_sha,rsa_rc2_40_md5,rsa_rc4_128_md5,rsa_rc4_128_sha,rsa_rc4_40_md5,fips_des_sha,fips_3des_sha,rsa_des_56_sha,rsa_rc4_56_sha,rsa_aes_128_sha,rsa_aes_256_sha,rsa_aes_128_gcm_sha_256,dhe_rsa_aes_128_gcm_sha_256,ecdh_ecdsa_null_sha,ecdh_ecdsa_rc4_128_sha,ecdh_ecdsa_3des_sha,ecdh_ecdsa_aes_128_sha,ecdh_ecdsa_aes_256_sha,ecdhe_ecdsa_null_sha,ecdhe_ecdsa_rc4_128_sha,ecdhe_ecdsa_3des_sha,ecdhe_ecdsa_aes_128_sha,ecdhe_ecdsa_aes_256_sha,ecdh_rsa_null_sha,ecdh_rsa_128_sha,ecdh_rsa_3des_sha,ecdh_rsa_aes_128_sha,ecdh_rsa_aes_256_sha,echde_rsa_null,ecdhe_rsa_rc4_128_sha,ecdhe_rsa_3des_sha,ecdhe_rsa_aes_128_sha,ecdhe_rsa_aes_256_sha,ecdhe_ecdsa_aes_128_gcm_sha_256,ecdhe_rsa_aes_128_gcm_sha_256"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the OpenSSL ciphers as well, since they are currently pinned at those offered by Firefox 51.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a task for another day, though.

@Hainish Hainish Nov 21, 2017 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also ensure that the macOS development environment doesn't use NSS. Though I'm unsure how well macOS is supported in general, and I was unable to test this.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added that _DEFAULT_CIPHERLIST_NSS line specifically when I was working on Fedora last year. It seems unlikely that macOS needs it. I understand wanting to test it, though.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this also doesn't solve all the problems with Fedora, I'm still running into errors when I try to run the test in docker. This should at least get Fedora systems to a point where the dependencies are installed, though.

Comment thread install-dev-dependencies.sh Outdated
if [ "$1" != "--no-prompt" ]; then
echo
echo "Warning: Installing the development dependencies for HTTPS Everywhere"
echo "may alter your system, installing requrements both within the package"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requirements

…a. Only prompt once at the beginning, with a warning. Fixes EFForg#13597
@Hainish
Hainish force-pushed the fix-install-dev-deps branch from 387cc5c to 64c0476 Compare November 21, 2017 18:30
@Hainish
Hainish merged commit 9e48776 into EFForg:master Nov 21, 2017
@Hainish
Hainish deleted the fix-install-dev-deps branch February 23, 2018 01:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants