Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Create Catbox.moe.xml - #13578

Merged
jeremyn merged 3 commits into
masterfrom
unknown repository
Dec 15, 2017
Merged

jeremyn merged 3 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Nov 12, 2017

Copy link
Copy Markdown

No description provided.

@Hainish Hainish added the top-1m label Nov 12, 2017

@Hainish Hainish left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!


<securecookie host=".+" name=".+" />

<rule from="^http://www\.catbox\.moe/" to="https://catbox.moe/" />

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This constitutes a snapping redirect, which we try to avoid. See https://github.com/EFForg/https-everywhere/blob/master/CONTRIBUTING.md#snapping-redirects

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snapping redirects are generally okay if they redirect "around" a broken URL, in this case avoiding www which has an invalid certificate. (This is implied by your link: "if https://foo.fm serves HTTPS correctly".) This is especially true for redirects between ^ and www, which should be very low-risk.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremyn Can you merge this one as well? (I ran travis again and fixed some problems FWIW)

@@ -0,0 +1,18 @@
<!--
Invalid Certificate:
www.catbox.moe

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see an invalid certificate here.

@ghost

ghost commented Nov 15, 2017 •

Copy link
Copy Markdown
Author

@Hainish I get an invalid certificate with both Firefox ESR and Firefox 57, you can try it here: https://www.browserling.com/browse/win/7/firefox/57/https%3A%2F%2Fwww.catbox.moe%2F

I suspect you tested it with Chromium where it doesn't happen. https://www.browserling.com/browse/win/7/chrome/61/https%3A%2F%2Fwww.catbox.moe%2F (Chromium tries https with ^ when www. fails, if you open the Developer Tools it says: Redirecting navigation www.catbox.moe -> catbox.moe because the server presented a certificate valid for catbox.moe but not for www.catbox.moe. To disable such redirects launch Chrome with the following flag: --disable-feature=SSLCommonNameMismatchHandling)

@ghost ghost mentioned this pull request Nov 21, 2017
@ghost ghost closed this Dec 13, 2017
@ghost ghost reopened this Dec 13, 2017
@jeremyn

jeremyn commented Dec 13, 2017

Copy link
Copy Markdown
Contributor

@Hainish This looks ready to merge, can you confirm?

@Hainish

Hainish commented Dec 15, 2017

Copy link
Copy Markdown
Member

@jeremyn Looks good to me.

@jeremyn
jeremyn merged commit 738e1d1 into EFForg:master Dec 15, 2017
@ghost
ghost deleted the patch-320 branch December 16, 2017 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants