Repository navigation
Create Catbox.moe.xml#13578
Conversation
|
|
||
| <securecookie host=".+" name=".+" /> | ||
|
|
||
| <rule from="^http://www\.catbox\.moe/" to="https://catbox.moe/" /> |
There was a problem hiding this comment.
This constitutes a snapping redirect, which we try to avoid. See https://github.com/EFForg/https-everywhere/blob/master/CONTRIBUTING.md#snapping-redirects
There was a problem hiding this comment.
Snapping redirects are generally okay if they redirect "around" a broken URL, in this case avoiding www which has an invalid certificate. (This is implied by your link: "if https://foo.fm serves HTTPS correctly".) This is especially true for redirects between ^ and www, which should be very low-risk.
There was a problem hiding this comment.
@jeremyn Can you merge this one as well? (I ran travis again and fixed some problems FWIW)
| @@ -0,0 +1,18 @@ | |||
| <!-- | |||
| Invalid Certificate: | |||
| www.catbox.moe | |||
There was a problem hiding this comment.
I don't see an invalid certificate here.
|
@Hainish I get an invalid certificate with both Firefox ESR and Firefox 57, you can try it here: https://www.browserling.com/browse/win/7/firefox/57/https%3A%2F%2Fwww.catbox.moe%2F I suspect you tested it with Chromium where it doesn't happen. https://www.browserling.com/browse/win/7/chrome/61/https%3A%2F%2Fwww.catbox.moe%2F (Chromium tries https with ^ when www. fails, if you open the Developer Tools it says: |
|
@Hainish This looks ready to merge, can you confirm? |
|
@jeremyn Looks good to me. |
No description provided.