Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Re-activate and Update Statistics.gov.uk.xml - #12888

Merged
J0WI merged 7 commits into
EFForg:masterfrom
cschanaj:statistics.gov.uk
Oct 5, 2017
Merged

J0WI merged 7 commits into
EFForg:masterfrom
cschanaj:statistics.gov.uk

Conversation

@cschanaj

@cschanaj cschanaj commented Oct 1, 2017

Copy link
Copy Markdown
Collaborator

No description provided.

@Hainish Hainish added the top-1k label Oct 1, 2017
@cschanaj cschanaj mentioned this pull request Oct 1, 2017
40 of 48 tasks
<!-- Redirect drops forward slash and args:
-->
<rule from="^http://www\.statistics\.gov\.uk/.*"
to="https://www.gov.uk/government/statistics/announcements" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we keep that one?

<target host="www.neighbourhood.statistics.gov.uk" />

<rule from="^http://www\.statistics\.gov\.uk/.*"
to="https://www.gov.uk/government/statistics/announcements" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That behavior seems wrong: http://www.statistics.gov.uk/invalid

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean that I should also include the exclusion in the old ruleset?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, or you change the rule to only match specific urls.
And please remove is the .* in the expression.

@J0WI

J0WI commented Oct 4, 2017

Copy link
Copy Markdown
Contributor

Please check the test coverage exposed by Travis.

@cschanaj

cschanaj commented Oct 4, 2017

Copy link
Copy Markdown
Collaborator Author

@J0WI Travis passing now. thanks!

@J0WI
J0WI merged commit b2acb72 into EFForg:master Oct 5, 2017
@cschanaj
cschanaj deleted the statistics.gov.uk branch October 5, 2017 22:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants