This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
Merged
Update merge-rulesets.sh#12739
Conversation
Author
Hainish
reviewed
Oct 21, 2017
| # prevents inodes from wasting disk space, but more importantly, works around | ||
| # the fact that zip does not perform well on a pile of small files. | ||
| # Merge all the .xml rulesets into a single "default.rulesets" file -- this prevents inodes from wasting disk space, but more importantly, | ||
| # works around the fact that zip does not perform well on a pile of small files. |
Author
There was a problem hiding this comment.
There's no need to limit line length to 80 chars.
Author
There was a problem hiding this comment.
All modern editors allow the user to choose the word wrap.
Member
There was a problem hiding this comment.
Yet most styles still prefer it. Take PEP 8, which instructs wrapping at 79 characters. That's python, this is bash, but wrapping is still useful. Wrapping a comment line can be quite ugly in some editors. Let's keep the wrapping, it's orthogonal to the separate change in this PR.
| RULESETS=chrome/content/rules/default.rulesets | ||
|
|
||
| # We make default.rulesets at build time, but it shouldn't have a variable timestamp. | ||
| touch -r src/install.rdf src/$RULESETS |
Member
There was a problem hiding this comment.
I don't see how this is a substantive improvement. Care to explain?
Author
There was a problem hiding this comment.
I moved this out of the Python script into the shell script.
Member
|
Looks good, thanks @koops76 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.