Repository navigation
Update hsts-prune/index.js - #12145
Conversation
|
@cschanaj So, Developer Edition is a re-brand of Beta? Interesting. |
|
Multiple source from Mozilla suggest so. Anything wrong? |
|
Firefox Developer Edition is a rebrand of Aurora according to https://developer.mozilla.org/en-US/Firefox/Developer_Edition :
However the last modified date for |
|
@jeremyn The version number is identical to Beta. |
|
Oh okay, thanks. It looks like Mozilla actually dropped Aurora according to https://hacks.mozilla.org/2017/04/simplifying-firefox-release-channels/ :
I wonder if "based on" means that Mozilla modifies something in the beta source before releasing it as Developer Edition. |
|
@jeremyn They probably do. There do not seem to be a source specifically for Developer Edition anywhere. I think we should ask Mozilla. |
|
According to the article What is Firefox Nightly?, Firefox Aurora is a release in-between the Beta and Nightly versions. It is a policy decision we have to made to choose which version to use (since Personally, I prefer replacing Aurora with Beta since it is always intended to be the next Release (while Nightly could be the Release after the next Release). This guarantees See https://wiki.mozilla.org/Firefox/Channels for the source code of different "Editions" |
|
I've added some thoughts to #12139. I should also note that Firefox Stable and ESR currently DO NOT use the new format, only Nightly (and maybe Beta) does, so you may need to have two code paths (I haven't really dug into it much further than that, so maybe your code does actually handle both cases). Statistics after this PR: 46 rulesets (0.20%) completely removed, totaling 23.6kB (0.12%) |
|
@bardiharborow both Beta and Nightly use the new format currently, and the modified code handle both formats. If @Hainish decides that we should use Nightly insteads, I can replace |
|
@cschanaj either this did not have the intended effect, or something has changed since this was merged. The following code injected into console.log(Object.keys(structs.esr).length, Object.keys(structs.dev).length, Object.keys(structs.stable).length, Object.keys(structs.chromium).length);Results in: The Firefox Beta preload list is not being parsed correctly. |
|
@bardiharborow a breaking change has been introduced in 3849a13bc8ce in |
ping @Hainish should fix #12139 but sort of dirty.
Travis build failed for unknown reason...