Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update hsts-prune/index.js - #12145

Merged
Hainish merged 1 commit into
EFForg:masterfrom
cschanaj:hsts-fix
Aug 31, 2017
Merged

Hainish merged 1 commit into
EFForg:masterfrom
cschanaj:hsts-fix

Conversation

@cschanaj

@cschanaj cschanaj commented Aug 27, 2017 •

Copy link
Copy Markdown
Collaborator

ping @Hainish should fix #12139 but sort of dirty.

Travis build failed for unknown reason...

@cschanaj cschanaj closed this Aug 27, 2017
@cschanaj cschanaj reopened this Aug 27, 2017
@cschanaj cschanaj closed this Aug 27, 2017
@cschanaj cschanaj reopened this Aug 27, 2017
@ghost

ghost commented Aug 27, 2017 •

Copy link
Copy Markdown

@cschanaj So, Developer Edition is a re-brand of Beta? Interesting.

@cschanaj

Copy link
Copy Markdown
Collaborator Author

@jeremyn

jeremyn commented Aug 28, 2017

Copy link
Copy Markdown
Contributor

Firefox Developer Edition is a rebrand of Aurora according to https://developer.mozilla.org/en-US/Firefox/Developer_Edition :

Firefox Developer Edition replaces the Aurora channel in the Firefox Release Process.

However the last modified date for mozilla-aurora at https://hg.mozilla.org/releases is 2017-05-15 which is too old, with mozilla-release having a date of 2017-08-26. I don't know where else to find the Developer Edition source though. Where is it?

@ghost

ghost commented Aug 28, 2017

Copy link
Copy Markdown

@jeremyn The version number is identical to Beta.

@jeremyn

jeremyn commented Aug 28, 2017

Copy link
Copy Markdown
Contributor

Oh okay, thanks. It looks like Mozilla actually dropped Aurora according to https://hacks.mozilla.org/2017/04/simplifying-firefox-release-channels/ :

Starting on April 18, the Firefox Aurora channel will stop updating, and over the course of the next several months, the Aurora build will be removed from the train release cycle. Developer Edition will be based on the Beta build.

I wonder if "based on" means that Mozilla modifies something in the beta source before releasing it as Developer Edition.

@ghost

ghost commented Aug 28, 2017

Copy link
Copy Markdown

@jeremyn They probably do. There do not seem to be a source specifically for Developer Edition anywhere. I think we should ask Mozilla.

@cschanaj

cschanaj commented Aug 28, 2017 •

Copy link
Copy Markdown
Collaborator Author

According to the article What is Firefox Nightly?, Firefox Aurora is a release in-between the Beta and Nightly versions. It is a policy decision we have to made to choose which version to use (since hsts-prune ONLY remove target when they are preloaded in all supported browser, simultaneously) .

Personally, I prefer replacing Aurora with Beta since it is always intended to be the next Release (while Nightly could be the Release after the next Release). This guarantees hsts-prune remove target if and only if the current and next Release preloaded it.

See https://wiki.mozilla.org/Firefox/Channels for the source code of different "Editions"

@bardiharborow

bardiharborow commented Aug 28, 2017 •

Copy link
Copy Markdown
Contributor

I've added some thoughts to #12139. I should also note that Firefox Stable and ESR currently DO NOT use the new format, only Nightly (and maybe Beta) does, so you may need to have two code paths (I haven't really dug into it much further than that, so maybe your code does actually handle both cases).

Statistics after this PR: 46 rulesets (0.20%) completely removed, totaling 23.6kB (0.12%)

@cschanaj

Copy link
Copy Markdown
Collaborator Author

@bardiharborow both Beta and Nightly use the new format currently, and the modified code handle both formats. If @Hainish decides that we should use Nightly insteads, I can replace mozilla-beta with mozilla-central in the URI. thanks!

@cschanaj cschanaj closed this Aug 29, 2017
@cschanaj cschanaj reopened this Aug 29, 2017
@ghost ghost mentioned this pull request Aug 31, 2017
@Hainish
Hainish merged commit b5759b3 into EFForg:master Aug 31, 2017
@cschanaj
cschanaj deleted the hsts-fix branch August 31, 2017 02:32
@bardiharborow

bardiharborow commented Sep 24, 2017 •

Copy link
Copy Markdown
Contributor

@cschanaj either this did not have the intended effect, or something has changed since this was merged.

The following code injected into utils/hsts-prune/index.js:

console.log(Object.keys(structs.esr).length, Object.keys(structs.dev).length, Object.keys(structs.stable).length, Object.keys(structs.chromium).length);

Results in:

25431 0 25431 32798

The Firefox Beta preload list is not being parsed correctly.

@cschanaj

Copy link
Copy Markdown
Collaborator Author

@bardiharborow a breaking change has been introduced in 3849a13bc8ce in 2017-09-15 as per https://bugzilla.mozilla.org/show_bug.cgi?id=1382001. We will need to modify our script in order to parse the list correctly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hsts-prune is still pointed to the discontinued Firefox Aurora release

4 participants