Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

add rule for sony.com.au (fix #11997) - #12053

Merged
gloomy-ghost merged 4 commits into
EFForg:masterfrom
J0WI:sony-au
Aug 27, 2017
Merged

gloomy-ghost merged 4 commits into
EFForg:masterfrom
J0WI:sony-au

Conversation

@J0WI

@J0WI J0WI commented Aug 22, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@@ -0,0 +1,26 @@
<!--
For other Sony coverage, see
+ Sony.xml

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- Sony.xml


h: http redirect
m: certificate mismatch
r: connection refused

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could replace (r) and (t) at the top with (connection refused) and (timeout on https) and remove this list?

<target host="pulselive.sony.com.au" />
<target host="sites.sony.com.au" />
<target host="store.sony.com.au" />

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add <securecookie host=".+" name=".+" />.

s: self-signed certificate
t: timeout on https
-->
<ruleset name="Sony.com.au">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a space between the comment and the ruleset tag?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have no strict guideline for comments...

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to have and enforce ruleset formatting guidelines for all new rulesets.

+ Sony.xml

Nonfunctional hosts in *.sony.com.au:
- sony.com.au (r)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to spell the domain name out since you already specified it's a subdomain of sony.com.au.

@cschanaj

Copy link
Copy Markdown
Collaborator

@J0WI I have updated several sony.com related rulesets in the last month and I would like to keep the comment style consistent among them. Please use + for reference to other rulesets, and - for domains in full (like #11609), i.e. no change is required.

P.S. it should be sony.com.au in the title.

<target host="sony.com.au" />
<target host="www.sony.com.au" />
<target host="partner.sony.com.au" />
<target host="pro.sony.com.au" />

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

@J0WI J0WI changed the title add rule for sonic.com.au (fix #11997) add rule for sony.com.au (fix #11997) Aug 27, 2017
@J0WI

J0WI commented Aug 27, 2017

Copy link
Copy Markdown
Contributor Author

Note: 236f27e has a typo in the commit message (s/sonic/sony/). I can rebase this PR after review or you just correct it during squash.

@gloomy-ghost
gloomy-ghost merged commit 7930180 into EFForg:master Aug 27, 2017
@J0WI
J0WI deleted the sony-au branch August 27, 2017 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants