Repository navigation
add rule for sony.com.au (fix #11997) - #12053
Conversation
| @@ -0,0 +1,26 @@ | |||
| <!-- | |||
| For other Sony coverage, see | |||
| + Sony.xml | |||
|
|
||
| h: http redirect | ||
| m: certificate mismatch | ||
| r: connection refused |
There was a problem hiding this comment.
Maybe you could replace (r) and (t) at the top with (connection refused) and (timeout on https) and remove this list?
| <target host="pulselive.sony.com.au" /> | ||
| <target host="sites.sony.com.au" /> | ||
| <target host="store.sony.com.au" /> | ||
|
|
There was a problem hiding this comment.
Add <securecookie host=".+" name=".+" />.
| s: self-signed certificate | ||
| t: timeout on https | ||
| --> | ||
| <ruleset name="Sony.com.au"> |
There was a problem hiding this comment.
Maybe add a space between the comment and the ruleset tag?
There was a problem hiding this comment.
We have no strict guideline for comments...
There was a problem hiding this comment.
We need to have and enforce ruleset formatting guidelines for all new rulesets.
| + Sony.xml | ||
|
|
||
| Nonfunctional hosts in *.sony.com.au: | ||
| - sony.com.au (r) |
There was a problem hiding this comment.
You don't need to spell the domain name out since you already specified it's a subdomain of sony.com.au.
| <target host="sony.com.au" /> | ||
| <target host="www.sony.com.au" /> | ||
| <target host="partner.sony.com.au" /> | ||
| <target host="pro.sony.com.au" /> |
|
Note: 236f27e has a typo in the commit message (s/sonic/sony/). I can rebase this PR after review or you just correct it during squash. |
No description provided.