Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update nexusmods.com.xml (fixes #11953) - #11961

Closed
ghost wants to merge 2 commits into
masterfrom
unknown repository
Closed

ghost wants to merge 2 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Aug 17, 2017

Copy link
Copy Markdown

No description provided.

@ghost ghost mentioned this pull request Aug 17, 2017
@cschanaj

Copy link
Copy Markdown
Collaborator

also fix #11970

@ghost

ghost commented Aug 18, 2017

Copy link
Copy Markdown
Author

@cschanaj Likely the same issue.

@ghost

ghost commented Aug 18, 2017

Copy link
Copy Markdown
Author

How do I apply this fix?

@ghost

ghost commented Aug 18, 2017

Copy link
Copy Markdown
Author

@umisery Simply wait until it will be merged, the next release will have it. Until then disable NexusMods.com ruleset.

@ghost

ghost commented Aug 18, 2017

Copy link
Copy Markdown
Author

Alright, thanks.

@springacres

Copy link
Copy Markdown

@umisery also, make sure to disable the ruleset before you log in to any nexusmods.com site.

@ghost

ghost commented Aug 19, 2017

Copy link
Copy Markdown
Author

I have no idea how to do either of those, so I'm just going to wait for it to be merged :P

<target host="nexusmods.com" />
<target host="www.nexusmods.com" />
<target host="filedelivery.nexusmods.com" />
<target host="forums.nexusmods.com" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add staticdelivery.nexusmods.com?

@@ -1,11 +1,11 @@
<!--
Mixed content:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth to create a MCB platform rule for them?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe but unlikely. I don't think anyone actually has active mixed content blocking disabled after Tor Browser enabled it. I think platform="mixedcontent" rulesets are on their way out.

@J0WI

J0WI commented Aug 24, 2017 •

Copy link
Copy Markdown
Contributor

I think we can just add an exclusion to fix the mentioned issues. Other parts of the site WFM.

@ghost

ghost commented Aug 31, 2017

Copy link
Copy Markdown
Author

@Hainish Merge before the release, NexusMods.com is broken.

@Hainish

Hainish commented Aug 31, 2017

Copy link
Copy Markdown
Member

We should set a policy on what rules are worthy of blocking release for. Looks like this one ranks 1,070, hardly a show-blocker.

@J0WI

J0WI commented Aug 31, 2017

Copy link
Copy Markdown
Contributor

This should not be a blocker for the current release. #12268 has a much bigger impact than any ruleset.

@koops76 I already commented on your changes. When we remove the entry host we don't fix anything, we just disable it.

@cschanaj

Copy link
Copy Markdown
Collaborator

In #11953 (comment), it is mentioned that

To confirm, Nexus Mods does not currently support HTTPS on the main site as per the following forum thread: https://forums.nexusmods.com/index.php?/topic/5907893-site-problems-an-error-occurred/

A number of users have experienced issues with this site (see #11953, #12324 and #12505). IMHO, We should disable this ruleset if it is impossible to fix. (Possibly with default_off="other" and a reference to the forum link). thanks.

@J0WI J0WI added this to the Before the Next Release milestone Sep 16, 2017
@J0WI J0WI mentioned this pull request Sep 18, 2017
@ghost ghost closed this Sep 18, 2017
@ghost
ghost deleted the patch-2 branch September 18, 2017 21:18
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants