This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
Merged
Update background.js#11807
Conversation
Hainish
reviewed
Aug 11, 2017
| function setStorage(values) { | ||
| return new Promise(resolve => { | ||
| storage.set(values, resolve); | ||
| } |
Member
There was a problem hiding this comment.
Add closing parenthesis here. Also, I'd rather have this in the import_settings function. Just call await to the promise. But consolidating the four separate calls is 👍.
Member
|
Great now
|
Author
|
@Hainish Done. |
Member
|
Thanks! |
ghost
deleted the
patch-2
branch
August 11, 2017 05:05
luciancor
pushed a commit
to luciancor/https-everywhere
that referenced
this pull request
Aug 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.