Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Do not process URLs that use file or ftp scheme - #11231

Closed
ghost wants to merge 6 commits into
masterfrom
unknown repository
Closed

ghost wants to merge 6 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Jul 18, 2017

Copy link
Copy Markdown

@J0WI

J0WI commented Jul 19, 2017

Copy link
Copy Markdown
Contributor

*://*/* does still match ftp://foo/bar. Maybe http is enough? (see #10843)
cc @Hainish

@ghost

ghost commented Jul 19, 2017

Copy link
Copy Markdown
Author

@ghost

ghost commented Jul 19, 2017 •

Copy link
Copy Markdown
Author

@J0WI http isn't currently enough.

@J0WI J0WI removed the conflict label Jul 19, 2017
Comment thread chromium/background.js Resolved
Comment thread chromium/manifest.json Resolved
@Hainish

Hainish commented Jul 19, 2017

Copy link
Copy Markdown
Member

Merged in 8e302ec

@Hainish Hainish closed this Jul 19, 2017
@ghost
ghost deleted the patch-107 branch July 21, 2017 08:36
luciancor pushed a commit to luciancor/https-everywhere that referenced this pull request Aug 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants