Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Create Nofap.com.xml - #11153

Closed
HTTPSNowhere wants to merge 2 commits into
EFForg:masterfrom
HTTPSNowhere:patch-2
Closed

HTTPSNowhere wants to merge 2 commits into
EFForg:masterfrom
HTTPSNowhere:patch-2

Conversation

@HTTPSNowhere

Copy link
Copy Markdown
Contributor

No description provided.

<target host="nofap.com" />
<target host="www.nofap.com" />
<target host="store.nofap.com" />

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add <securecookie host=".+" name=".+" />.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koops76 Done!

@HTTPSNowhere

Copy link
Copy Markdown
Contributor Author

Partially fixes: #5055

@jeremyn

jeremyn commented Dec 6, 2017

Copy link
Copy Markdown
Contributor

@HTTPSNowhere Are you still interested in working on this pull request?

@jeremyn

jeremyn commented Dec 22, 2017

Copy link
Copy Markdown
Contributor

I'm closing this pull request due to lack of response from @HTTPSNowhere . I've noted nofap.com at https://github.com/EFForg/https-everywhere/issues/3069#issuecomment-353648503 in case someone else wants to make a pull request for this domain.

@J0WI

J0WI commented Dec 22, 2017

Copy link
Copy Markdown
Contributor

@HTTPSNowhere Are you still interested in working on this pull request?

@jeremyn I think you closed that one to early. There was no pending feedback to continue working on.

@jeremyn

jeremyn commented Dec 22, 2017 •

Copy link
Copy Markdown
Contributor

@J0WI It is a waste of time to provide feedback on a PR if the contributor has abandoned it.

If you want to talk about how pending closure works in more detail, let's do that in issue #13859.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants