This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
[GoogleMaps] Simplify ruleset - #11070
Merged
Merged
Conversation
J0WI
reviewed
Jul 21, 2017
| <exclusion pattern="^http://maps\.google\.gr/transitathens" /> | ||
| <test url="http://maps.google.gr/transitathens" /> | ||
| <test url="http://maps.google.ca/" /> | ||
| <test url="http://maps.google.com/" /> |
Contributor
There was a problem hiding this comment.
Please add at least 3 for each wildcard.
J0WI
approved these changes
Jul 21, 2017
Contributor
Contributor
|
Oh, this needs to be rebased first. |
luciancor
pushed a commit
to luciancor/https-everywhere
that referenced
this pull request
Aug 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know this is important we don't break anything here so please take your time to review. I can also understand if you prefer to keep some more complicated rules for clarity.