Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Idea/suggestion: Include total count when some rules are inactive - #1035

Closed
fuglede wants to merge 2 commits into
EFForg:masterfrom
fuglede:newcounter
Closed

fuglede wants to merge 2 commits into
EFForg:masterfrom
fuglede:newcounter

Conversation

@fuglede

@fuglede fuglede commented Feb 10, 2015

Copy link
Copy Markdown
Contributor

One thing that has bugged me a few times is that there's no way to tell if one is browsing a site that supports a ruleset which is disabled per default. These commits fix this by adding the total count of rules, in the case where some are inactive. See this screenshot.

Pro:

  • Makes it easier to identify the possibility of activating rules that are otherwise hidden in the toolbar button menu.

Some cons:

  • Only really useful to people who don't mind experimenting with broken rulesets
  • Clutters the interface ever so slightly. This is mitigated by only changing the label when the total count differs from the active count.

(Also, a question: does the ApplicableList have a counter itself?)

@jsha

jsha commented Feb 12, 2015

Copy link
Copy Markdown
Member

I think for the average user, this is too much clutter. If you want to add this as a preference, I think that would be fine. Also, if you want to port the counter code into ApplicableList that would be great.

@reedy reedy added the firefox label Apr 13, 2015
@reedy reedy changed the title Idea/suggestion: Include total count when some rules are inactive [Firefox] Idea/suggestion: Include total count when some rules are inactive Apr 13, 2015
@fuglede fuglede closed this May 17, 2015
@fuglede
fuglede deleted the newcounter branch August 3, 2015 20:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants