Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Audit default_off rulesets #9842

Closed
Closed

Description

@cschanaj

Type: ruleset issue

Domain: *

Similar to #9582, I suspect 168 out of 537 default_off="self-signed" rulesets can be re-activated. I added a date to PRs which haven't been merge after being reviewed for a long time.

Self-signed

HSTS

Qualified but not preloaded

  • tr0n.net

HSTS Preloaded

HSTS

Strict-Transport-Security: max-age >= 10886400; includeSubDomains

HSTS

Strict-Transport-Security: max-age < 10886400; includeSubDomains

local issuser certificates

Activity

  1. Bisaloo commented on May 8, 2017

    @Bisaloo
    Collaborator
  2. Bisaloo commented on May 8, 2017

    @Bisaloo
    Collaborator

    For your script, you should note that sometimes several reasons are listed for default_off. Do you currently catch such rulesets?

    For example, WorkWithColor.xml (although it is maybe not the best example as it is still broken but you get the idea).

  3. cschanaj commented on May 8, 2017

    @cschanaj
    CollaboratorAuthor

    @Bisaloo You are right, the same hold true for #9582. The script I use now only check if default_off="self-signed" is a full-match.

    I can make a generic script such that it works when we would like to audit on mismatch, cacert, self-signed etc (maybe tonight).

    P.S. If you don't care about the terrible performance, you can do

    grep -il 'default_off=\".*self-signed.*\"' *.xml

    in the corresponding directory.

  4. cschanaj commented on May 8, 2017

    @cschanaj
    CollaboratorAuthor

    You can now refer to the newly created script on GIST. (Performance-wise I believe it can be further optimized). To use the script, you need to set the KEYWORD variable, for example

    $ export KEYWORD="self-signed"
    $ ./audit.sh
    

    P.S. I will update the above list accordingly.

  5. Bisaloo commented on Jun 2, 2017

    @Bisaloo
    Collaborator

    I'd argue that resonant.org is still self-signed:

  6. cschanaj commented on Jun 2, 2017

    @cschanaj
    CollaboratorAuthor

    @Bisaloo I agree that resonant.org is still self-signed. Updated the list accordingly, thanks a lot!!

  7. Bisaloo commented on Jun 8, 2017

    @Bisaloo
    Collaborator

    I found 118 additional domains with your script by running grep with (60, 'SSL certificate problem: unable to get local issuer certificate').

    Should I add them to this list or open a different issue? It's likely that among those 118 domains, not all of them were disabled due to being self-signed but also because of chain issues or the use of alternative authorities like CAcert.

  8. cschanaj commented on Jun 8, 2017

    @cschanaj
    CollaboratorAuthor

    @Bisaloo Please feel free to add them to this PR if you want, I do not mind updating the checklist for this. Thanks!!

  9. changed the title [-]Audit default_off 'self-signed' rulesets[/-] [+]Audit default_off rulesets[/+] on Jun 8, 2017
  10. Bisaloo commented on Jun 8, 2017

    @Bisaloo
    Collaborator

    Great! The list is here (or you can copy it directly with the checkboxes here.)

  11. https-everywhere-bot commented on Dec 13, 2017

    @https-everywhere-bot

    I still don't see the type of issue in your description. Can you edit your issue to add this (perhaps referring to the issue template?)

  12. https-everywhere-bot commented on Dec 13, 2017

    @https-everywhere-bot

    Thanks! Your edit helped me out. I'll take it from here now.

  13. J0WI commented on Jun 15, 2018

    @J0WI
    Contributor

    Can we close this in favor of smaller issues (e.g. #13290, #13176, #13088)?

  14. cschanaj commented on Jun 16, 2018

    @cschanaj
    CollaboratorAuthor

    @J0WI I agree. let's close this in favor of small issues 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions