Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Why is autotools.io in ruleset-coverage-whitelist.txt? #9627

Closed

Description

@Bisaloo

It doesn't look like the ruleset for autotools.io has coverage issues to me.

So why is it listed in ruleset-coverage-whitelist?

The issue is that the hash of the current file matches the hash listed in the whitelist so it won't be remove by ruleset-coverage-whitelist-cleanup.sh.

sha256sum Autotools.io.xml | cut -c-64

1074d5e1178a297d7bca2c929df0be05e154ae62bd4f4e705a25240562791955

Activity

  1. cschanaj commented on Apr 23, 2017

    @cschanaj
    Collaborator

    The same thing holds true for www.mint.com. The ruleset Mint.xml looks fine to me, yet it is listed Here which has the same hash.

    Reading through 0d5c34f, I am a little bit confused. Does the following mean that all the ruleset exist prior to 2014-02-12 are added to the white-list? That is, if a ruleset hasn't been updated after that, its entry will always residue in the white-list.

    Instead, we create a list of SHA256 hashes of files as they stood on 2014-02-12 (plus some extras that slipped through because the changes were made before then but merged later). When running coverage tests, and files that match those hashes are ignored.

  2. J0WI commented on May 11, 2017

    @J0WI
    Contributor

    We didn't have any tests in 2014, so all existing rules have been white listed.

  3. Bisaloo commented on May 17, 2017

    @Bisaloo
    CollaboratorAuthor

    Thank you @J0WI. Could you tag this as question please? In case someone happens to have the same question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions