Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Don't mess with localhost URLs #8242

Closed
Closed

Description

@strugee

With "block all unencrypted requests" enabled, HTTPS Everywhere tries to rewrite localhost URLs to use HTTPS, which is unideal. We probably shouldn't do that.

Also relevant: https://www.w3.org/TR/secure-contexts/#localhost

Activity

  1. exegeteio commented on Feb 18, 2017

    @exegeteio

    +1 👍 - For all the web developers out there.

  2. Kibouo commented on Feb 21, 2017

    @Kibouo

    +1
    Really annoying that it messes with localhost

  3. Ryuno-Ki commented on Mar 2, 2017

    @Ryuno-Ki

    Affects both, http://127.0.0.1:<PORT> as well as http://localhost:<PORT>.
    Pretty annoying.

  4. Ryuno-Ki commented on Mar 2, 2017

    @Ryuno-Ki

    URI.find_uri_expression = /\b((?:http:(?:\/{1,3}|[a-z0-9%])|www\d{0,3}[.]|[a-z0-9.\-]+[.][a-z]{2,4}\/)(?:[^\s()<>]+)+(?:\(([^\s()<>]+|(\([^\s()<>]+\)))*\)|[^\s`!()\[\]{};:'".,<>?«»“”‘’]))/ig;
    looks like the line in question.

    At this point I would long have changed the regex to use RegExp … so it is possible to break it into smaller part, concatenate it and pass it to new RegExp().

  5. strugee commented on Mar 3, 2017

    @strugee
    ContributorAuthor

    Please stop commenting with +1s; it generates a lot of spam for subscribers/watchers.

    @Ryuno-Ki you should PR!

  6. Ryuno-Ki commented on Mar 3, 2017

    @Ryuno-Ki

    @strugee I have no experience with browser add-ons and would need some guidance for setting up dev environment and testing my patch.

  7. strugee commented on Mar 3, 2017

    @strugee
    ContributorAuthor

    @Ryuno-Ki https://github.com/EFForg/https-everywhere#getting-started has some instructions for getting started with HTTPS Everywhere development. I've only dabbled in HTTPS Everywhere development but I'd be happy to try and help, or I'm sure you could ping one of the core developers.

  8. Hainish commented on Mar 3, 2017

    @Hainish
    Member

    @Ryuno-Ki Let me know if you plan to PR, otherwise I can add a localhost exception.

  9. Hainish commented on Mar 4, 2017

    @Hainish
    Member

    1dafcc9 resolves this. It will be deployed in 5.2.12

  10. Mikaela commented on Apr 7, 2020

    @Mikaela
    Contributor

    I am not sure this is fixed or has been reintroduced as HTTPS Everywhere is now conflicting with IPFS Companion using *.localhost addresses and those get https and errors when EASE mode is enabled.

  11. locked as resolved and limited conversation to collaborators on Apr 7, 2020
  12. pipboy96 commented on Apr 7, 2020

    @pipboy96
    Contributor

    @Mikaela Please don't bump old issues if possible. Create a new issue instead. Thanks for reporting the issue though, this will be looked into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions