Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Broken on Firefox Nightly #7676

Closed
Closed

Description

@gitarra

Addon does not work on Firefox Nightly.

I am getting for syntax error in Browser Console.

for each(var cb in [channel.notificationCallbacks,

Disable non-standard for-each:
https://bugzilla.mozilla.org/show_bug.cgi?id=1293305

Activity

  1. jeremyn commented on Nov 23, 2016

    @jeremyn
    Contributor

    @Hainish Pinging you to make you aware of this. We don't want another #5874 .

  2. numismatika commented on Nov 24, 2016

    @numismatika
    Contributor

    I have seen that the menu is partially broken on my FF53 nightly , the top half is gone. Might be related.
    This should have at least 1 rule marked active in the menu. Even more depending on external ad load.
    cut-off

  3. jeremyn commented on Nov 24, 2016

    @jeremyn
    Contributor

    @smw-koops Does your pull request fix the problem @numismatika reported in the previous comment?

  4. numismatika commented on Nov 26, 2016

    @numismatika
    Contributor

    Is there a way to make a beta test release to find out?

  5. jeremyn commented on Nov 26, 2016

    @jeremyn
    Contributor

    @numismatika Yes. You want to build an .xpi as described in the README.

  6. numismatika commented on Nov 27, 2016

    @numismatika
    Contributor

    It doesn't like my Python Installation on Windows even if i try to install 2.7 again and lxml (which fails as well there).
    On Linux it fails with various whitelisting issues. Can't you just merge it upstream and release it?
    I don't think it would break.

  7. jeremyn commented on Nov 27, 2016

    @jeremyn
    Contributor

    @numismatika Development on Windows isn't really supported, see the discussion around #5584 (comment) . What problems are you having with Linux?

  8. AlexBeLi commented on Nov 27, 2016

    @AlexBeLi

    Maybe it make sense to use msys/msys2?

  9. jeremyn commented on Nov 29, 2016

    @jeremyn
    Contributor

    @AlexBeLi I don't think MSYS or Cygwin will work. I even tried the new Bash on Windows functionality a while ago (see #5584 (comment)) and that didn't work. I really recommend that anyone using Windows uses a Linux VM for HTTPS Everywhere development.

  10. numismatika commented on Nov 29, 2016

    @numismatika
    Contributor

    fixes my issue.
    I forgot to init the submodules before building the xpi, that's what broke it.

  11. jeremyn commented on Nov 29, 2016

    @jeremyn
    Contributor

    @numismatika So (re)running install-dev-dependencies.sh fixed the problem?

  12. numismatika commented on Nov 29, 2016

    @numismatika
    Contributor

    @jeremyn it was

    git submodule update --init --recursive

    Rulesets are visible again after building current master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions