Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Racked.com breaks images due to CORS issues #7381

Closed

Description

@mnordhoff

The Racked.com ruleset breaks all the images on (some?) articles due to CORS issues with XMLHttpRequest and www.racked.com.

URL: http://www.racked.com/2016/10/5/13165868/donald-trump-china-factories-neckties

Error: XMLHttpRequest cannot load https://www.racked.com/chorus_page/optimally_sized_images?imgkeys=51193119%3A*%3A18%3A1757x975%3Awebp&asset_keys=7219403%3A440%3A440%2C7219513%3A1317%3A1317%2C7219619%3A440%3A440%2C7219669%3A1317%3A1317. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://www.racked.com' is therefore not allowed access.

Do you think it would be better to add an exclusion or disable the ruleset entirely? The ruleset is of literally no use if the main page URL redirects to HTTP, the image thing is excluded, and all of the other elements are loaded from third-party domains, most of which are probably covered by other rulesets. Other pages may be in less dire shape, though.

Activity

  1. added a commit that references this issue on Oct 20, 2016
    ef23635
  2. mnordhoff commented on Oct 20, 2016

    @mnordhoff
    ContributorAuthor

    #4007 and #7312 are about the same issue on other Vox properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions