Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Release 5.2.6 forthcoming #7329

Closed
Closed

Description

@Hainish

cc @jsha @cooperq @pde @J0WI @fuglede @semenko @loveithateit @diracdeltas @jeremyn

Creating this issue early, but this is most likely to land late next week (probably Thursday)

Activity

  1. jeremyn commented on Oct 13, 2016

    @jeremyn
    Contributor

    It would be great if we could resolve #7317 for Firefox for Android before then, or at least confirm that it affects just that one domain.

  2. terrorist96 commented on Oct 13, 2016

    @terrorist96
    Contributor

    Can we also please set the following rules to default=off before the new update?
    #4510
    #4545
    #5086
    #5621

    Since they have been broken for several releases now (7 months for the oldest one) and no one has attempted to apply a fix yet. So let's set them to default=off until they get fixed, as per:
    #5631

    If I get approval, I'll make the PRs.

  3. fuglede commented on Oct 13, 2016

    @fuglede
    Contributor

    Adding one to the list, #7302 fixes a top-10k currently having its main functionality broken, so that could also be useful.

  4. jeremyn commented on Oct 13, 2016

    @jeremyn
    Contributor

    @terrorist96 I disagree that we should bulk disable rules just because no one has fixed an issue with them yet, especially these complex CDN rules that span multiple sites in unclear ways (see #4510 (comment)). Unfortunately the people who can decide that a rule is safe to disable are the same ones who are able to fix it, and the problem is we don't have enough of those people looking at issues.

    It's also a security concern. Perhaps I'm a malicious actor and want to disable a ruleset for one of these domains, so I report a fake issue with some other domain in the ruleset, with a problem that sounds tricky and hard-to-reproduce. Eventually I pressure the maintainers (us) to disable the entire ruleset until my fake issue is resolved, which will never happen.

  5. terrorist96 commented on Oct 13, 2016

    @terrorist96
    Contributor

    @jeremyn You can take a look at those issues and confirm that they break website functionality. Are you saying that you can't reproduce the issues?
    I'm simply agreeing with @Hainish that rules that are found to be causing problems should be disabled until fixed, then may be re-enabled. Do we want maximum security with the side effect of broken websites or decent security with no broken websites? We browse the web to use websites. If that site's functionality is broken, it pushes people away from tools like HTTPS Everywhere because the broken functionality is not worth the security tradeoff. Most people won't go through the trouble of debugging each ruleset to see which one is causing the problem. And even if they do, and they disable that rule, that rule becomes disabled globally, not just for that site, so the end result is the same: that rule becomes disabled. And since rulesets that break websites are allowed to persist (I'm not pointing any fingers here, I understand everyone is busy and this is more so a volunteer kind of thing), it makes me hard pressed to be able to recommend tools such as HTTPS Everywhere to my non-tech-savvy friends, because I'll get blamed for breaking their web experience. They won't see the enhanced security, but they will see videos on websites not loading, for example.
    So, help me be able to recommend more people use HTTPS Everywhere. 😅

  6. Hainish commented on Oct 13, 2016

    @Hainish
    MemberAuthor

    @terrorist96 @jeremyn this seems more like a question than a discussion that should happen on the release announce issue (not all the above mentioned people need to be privy to this discussion) - I've opened a new ticket #7338 , could you take the discussion there? Thanks

  7. jeremyn commented on Oct 13, 2016

    @jeremyn
    Contributor

    @Hainish Sure, will do.

  8. ivysrono commented on Oct 15, 2016

    @ivysrono
    Contributor

    #6994 to fix several broken.

  9. Hainish commented on Oct 21, 2016

    @Hainish
    MemberAuthor

    Release 5.2.6 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions