You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Shall we require additional review for top-100 rules? #6492
After #6424 comes up, I wonder if we should expand the review for the top-100 rules.
If these rules get manipulated or break functionality a huge part of all websites and users would be affected.
Usually, rules are just reviewed once and get merged then. We can improve quality and security when we require more persons to review them or require further testing.
I think it's okay if there is only one reviewer, just as long as they treat the top-100 sites with extra care. Already, it can take a long time for rulesets to get merged. We may be introducing an extra bottleneck if we require more than one reviewer, and for the sake of expediency we want the top-100 sites often to be merged quickly.
If we see problems down the road maybe we can revisit, but closing for now.
Activity
Hainish commentedon Aug 20, 2016
I think it's okay if there is only one reviewer, just as long as they treat the
top-100sites with extra care. Already, it can take a long time for rulesets to get merged. We may be introducing an extra bottleneck if we require more than one reviewer, and for the sake of expediency we want thetop-100sites often to be merged quickly.If we see problems down the road maybe we can revisit, but closing for now.