You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Cotsco is one of the biggest retailers in the US: http://www.costco.com ...when viewing images of products with https everywhere enabled, viewing product images by clicking the plus sign in the lower left corner of the main image brings up an applet that goes blank and cannot click any other images or even the "x" in the upper left to close the pop-up window - effectively breaking the site.
clicking the magnifying glass in the lower right part of the picture, below the card, and observing that clicking the X in the top right of the interstitial that appears does nothing other than throw messages to the JavaScript console. Turning off the Costco-static.com ruleset fixes the problem.
@fuglede@J0WI What's the fix here? Just disable the static ruleset entirely?
@jeremyn: I can not actually reproduce the issue as described in your comment: indeed I can not close the bigger version of the image, but disabling the ruleset (or HTTPS Everywhere in its entirety for that matter) does not appear to be sufficient to fix the faulty behaviour. I have not looked into it in any greater detail than that, but this also means that I can not quite tell what causes the issue right here and now. In general, the proper fix will depend on how you want to prioritize security versus breakage: it would be nice to pin down the issue exactly, for example to a specific static serving folder which you could then exclude, but often that can be rather involved, and if noone is around to do the job, and if the issue is likely to affect a lot of users (as in this case), it might very well be preferable to simply disable the ruleset. Different people will have different opinions, and I don't think anything has been written down on the matter, but my impression is that most of us prefer to avoid the usability issues even if it costs a bit of security somewhere else.
I just tested and same - disabling the Costco-static.com ruleset also made it work for me. Costco being as big a company as it is, highly doubtful we can get them to make any changes on their side unfortunately.
When I click the X to try to shut the popup down, the console reports
TypeError: document.getElementById(...).originalSize is not a function embed_costco.js:268:2
I tried adding <exclusion pattern="^http://images\.costco-static\.com/image/media/10024438-847__1_z/zoom\.info\.js$" /> to see if that helps, but it doesn't. Maybe some http URL is hardcoded in some Flash application.
Anyway I don't know. My recommendation is to disable the ruleset by default by adding default_off="https://github.com/EFForg/https-everywhere/issues/5377" to the ruleset tag. What do you two think?
The lack of Flash here could explain why the page did not respond at all, I guess, although I did see the same errors as you in the console, even without HTTPS Everywhere and Flash. I wanted to test with Flash as well, but it looks like their site is down right now.
In any case, if you do not see a straightforward fix, then disabling it might be better than the status quo indeed. Another possibility that I've applied a couple of times is to add an exclusion for all URLs ending with .js. Of course the active content is what we would want to secure the most, so depending on how you look at it, this is not a huge improvement over disabling it completely.
Activity
zeugmatis commentedon Jun 28, 2016
BTW tested in recent versions of Chrome and Firefox (both recent stable and nightly) on OSX El Capitan.
tomwys commentedon Aug 13, 2016
I got "Access Denied" when clicking that link. Is this only me, or website is completely broken?
zeugmatis commentedon Aug 19, 2016
I'm figuring the website is broken - I did let Costco know as well. Such a large US company though, they did not respond.
jeremyn commentedon Aug 19, 2016
FYI, I can specifically reproduce the problem by going here:
http://www.costco.com/Costco-Cash-Card.product.10024438.html
clicking the magnifying glass in the lower right part of the picture, below the card, and observing that clicking the X in the top right of the interstitial that appears does nothing other than throw messages to the JavaScript console. Turning off the Costco-static.com ruleset fixes the problem.
@fuglede @J0WI What's the fix here? Just disable the static ruleset entirely?
fuglede commentedon Aug 20, 2016
@jeremyn: I can not actually reproduce the issue as described in your comment: indeed I can not close the bigger version of the image, but disabling the ruleset (or HTTPS Everywhere in its entirety for that matter) does not appear to be sufficient to fix the faulty behaviour. I have not looked into it in any greater detail than that, but this also means that I can not quite tell what causes the issue right here and now. In general, the proper fix will depend on how you want to prioritize security versus breakage: it would be nice to pin down the issue exactly, for example to a specific static serving folder which you could then exclude, but often that can be rather involved, and if noone is around to do the job, and if the issue is likely to affect a lot of users (as in this case), it might very well be preferable to simply disable the ruleset. Different people will have different opinions, and I don't think anything has been written down on the matter, but my impression is that most of us prefer to avoid the usability issues even if it costs a bit of security somewhere else.
zeugmatis commentedon Aug 20, 2016
I just tested and same - disabling the Costco-static.com ruleset also made it work for me. Costco being as big a company as it is, highly doubtful we can get them to make any changes on their side unfortunately.
jeremyn commentedon Aug 21, 2016
I've reproduced the problem with Firefox 48.0.1 on Windows. It looks like the popup uses Flash so that should be enabled before trying this.
When I click the first magnifying glass to open the popup, the developer tools console reports:
When I click the X to try to shut the popup down, the console reports
I tried adding
<exclusion pattern="^http://images\.costco-static\.com/image/media/10024438-847__1_z/zoom\.info\.js$" />to see if that helps, but it doesn't. Maybe some http URL is hardcoded in some Flash application.Anyway I don't know. My recommendation is to disable the ruleset by default by adding
default_off="https://github.com/EFForg/https-everywhere/issues/5377"to the ruleset tag. What do you two think?fuglede commentedon Aug 21, 2016
The lack of Flash here could explain why the page did not respond at all, I guess, although I did see the same errors as you in the console, even without HTTPS Everywhere and Flash. I wanted to test with Flash as well, but it looks like their site is down right now.
In any case, if you do not see a straightforward fix, then disabling it might be better than the status quo indeed. Another possibility that I've applied a couple of times is to add an exclusion for all URLs ending with
.js. Of course the active content is what we would want to secure the most, so depending on how you look at it, this is not a huge improvement over disabling it completely.jeremyn commentedon Aug 22, 2016
I'm not planning to dig into this more myself anytime soon.
@zeugmatis @tomwys If one of you could submit a pull request either disabling this ruleset entirely, or adding a targeted exclusion to fix the problem, that would be great. Please refer to this issue in that pull request and I'll review it.
zeugmatis commentedon Aug 26, 2016
I'm super busy too, but if this sits here for a month (or three :-)) and is still open then I'll look into further and submit a PR.
pipboy96 commentedon Apr 5, 2019
Can't reproduce, website seems to be changed.