Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Ruleset release 5.1.9 #4710

Closed
Closed

Description

@Hainish

cc @jsha @cooperq @pde @J0WI @fuglede @semenko @loveithateit

I'll be releasing a ruleset release (5.1.7) hopefully today. I plan on cutting the release after reviewing and merging #4505

I'm going to start opening issues before a release is scheduled to let ruleset maintainers know when a release is forthcoming. I'll mention the main ruleset maintainers so they are notified. This will let the maintainers close loop on any PRs they are reviewing. This is a courtesy issue, and may or may not be followed upon every release, depending on circumstance.

I've also created a new label, release-forthcoming, to group these type of issues.

Activity

  1. Hainish commented on May 4, 2016

    @Hainish
    MemberAuthor

    Looks like this release may be pushed to tomorrow, as #4505 requires some auditing.

  2. diracdeltas commented on May 5, 2016

    @diracdeltas
    Contributor

    i'd like to be CC'ed too, as the https e maintainer for Brave. :)

  3. Hainish commented on May 5, 2016

    @Hainish
    MemberAuthor

    Sounds good, I'll include you as well

  4. Hainish commented on May 5, 2016

    @Hainish
    MemberAuthor

    Looks like the release will have to be pushed to tomorrow, due to complications arising from #4505 (comment)

  5. Hainish commented on May 6, 2016

    @Hainish
    MemberAuthor

    With #4505 merged, I'll be ready to make a release tomorrow for sure.

  6. Hainish commented on May 6, 2016

    @Hainish
    MemberAuthor

    Considering it now, it's better to make this release on Monday rather than late on a Friday afternoon.

  7. J0WI commented on May 9, 2016

    @J0WI
    Contributor

    Thanks for the announce.
    #4673, #4282 and #4433 seems trivial.
    #4471, #4178, #4370 and #4371 would be important to be released.

  8. Hainish commented on May 9, 2016

    @Hainish
    MemberAuthor

    Merged the trivial PRs. If we want to release today, we'll have to delay the non-trivial PRs to next release.

  9. Hainish commented on May 10, 2016

    @Hainish
    MemberAuthor

    A few problems came up while doing the release, pushing to tomorrow morning.

  10. J0WI commented on May 10, 2016

    @J0WI
    Contributor

    Can we have milestones for such cases?
    #4101 is also waiting for review btw.

  11. Hainish commented on May 10, 2016

    @Hainish
    MemberAuthor

    Milestones make sense to me, as long as we don't keep piling ruleset changes onto a single milestone.

  12. J0WI commented on May 10, 2016

    @J0WI
    Contributor

    Since the rules are not separated from the core it's hard to merge just rule bugfixes instead of rebased rules.
    Buggy rules could block a release, new or rebased ones shouldn't.

  13. changed the title [-]Ruleset release 5.1.7[/-] [+]Ruleset release 5.1.9[/+] on May 10, 2016
  14. Hainish commented on May 10, 2016

    @Hainish
    MemberAuthor

    Because of the aforementioned release issues, we've version-jumped to 5.1.9 for Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions