You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Looking at this ruleset, I think it should just be deleted.
content. could cause issues on any number of sites since we're talking JWPlayer here. dashboard. doesn't seem to be used anymore and forwards to account.jwplayer.com which is covered in the LongTail ruleset anyway.
We can try to exclude the xml file to work around the cors bugs. api.jwplatform.com is also missing, but in case we have to delete the rule we should merge them in LongTail.
In general, when rulesets, especially partial rulesets, are broken, I think we should just disable or delete them. In this case it sounds like there's a specific video provider (jwplatform) that is causing a lot of rules to break that used to work. Is that an accurate statement? @Hainish can you take a look?
Still broken in Version: 2016.5.10
I wish the policy would be to immediately deactivate rules that breaks websites, and only to reactivate them after the issue has been fixed, instead of leaving the rules active (i.e. sites broken) while waiting on a fix.
I made an exclusion for the affected xml files in #4787.
I didn't remove dashboard because it still works and there are some deep links that doesn't redirect.
Activity
funkydude commentedon Apr 2, 2016
Looking at this ruleset, I think it should just be deleted.
content.could cause issues on any number of sites since we're talking JWPlayer here.dashboard.doesn't seem to be used anymore and forwards toaccount.jwplayer.comwhich is covered in the LongTail ruleset anyway.@J0WI ?
J0WI commentedon Apr 3, 2016
We can try to exclude the xml file to work around the cors bugs.
api.jwplatform.comis also missing, but in case we have to delete the rule we should merge them in LongTail.terrorist96 commentedon Apr 11, 2016
Another example: http://www.wnd.com/2016/04/trump-erupts-as-cruz-sweeps-colorado-without-votes/
breaks both videos. First video is also broken by Google API. #4545
numismatika commentedon Apr 13, 2016
Has anyone tried to contact JW and ask them if they can't enable cors on their side to fix it?
J0WI commentedon Apr 13, 2016
Maybe someone official from the EFF could do that (@jsha).
Mostly the won't care about daily requests.
jsha commentedon Apr 14, 2016
In general, when rulesets, especially partial rulesets, are broken, I think we should just disable or delete them. In this case it sounds like there's a specific video provider (jwplatform) that is causing a lot of rules to break that used to work. Is that an accurate statement? @Hainish can you take a look?
terrorist96 commentedon May 13, 2016
Still broken in Version: 2016.5.10
I wish the policy would be to immediately deactivate rules that breaks websites, and only to reactivate them after the issue has been fixed, instead of leaving the rules active (i.e. sites broken) while waiting on a fix.
fixed EFForg#4531
J0WI commentedon May 14, 2016
I made an exclusion for the affected xml files in #4787.
I didn't remove
dashboardbecause it still works and there are some deep links that doesn't redirect.terrorist96 commentedon Jun 10, 2016
@Hainish @J0WI Still broken in 2016.6.9.
J0WI commentedon Jun 10, 2016
This has been fixed, your example depends on #4545 which indeed hasn't been fixed yet.
terrorist96 commentedon Jun 10, 2016
Nope. Disabling Google APIs and leaving JW active, the videos are still broken in both links.
J0WI commentedon Jun 10, 2016
Works for me on Firefox with a clean profile out of the box.
terrorist96 commentedon Jun 10, 2016
And it doesn't work for me on Chrome, in a clean profile, with only HTTPS Everywhere installed.
J0WI commentedon Jun 10, 2016
Please open a new issue for that.