Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

JW Platform.com (partial) breaks video #4531

Closed

Activity

  1. funkydude commented on Apr 2, 2016

    @funkydude
    Contributor

    Looking at this ruleset, I think it should just be deleted.

    content. could cause issues on any number of sites since we're talking JWPlayer here.
    dashboard. doesn't seem to be used anymore and forwards to account.jwplayer.com which is covered in the LongTail ruleset anyway.

    @J0WI ?

  2. J0WI commented on Apr 3, 2016

    @J0WI
    Contributor

    We can try to exclude the xml file to work around the cors bugs.
    api.jwplatform.com is also missing, but in case we have to delete the rule we should merge them in LongTail.

  3. terrorist96 commented on Apr 11, 2016

    @terrorist96
    ContributorAuthor

    Another example: http://www.wnd.com/2016/04/trump-erupts-as-cruz-sweeps-colorado-without-votes/

    breaks both videos. First video is also broken by Google API. #4545

  4. numismatika commented on Apr 13, 2016

    @numismatika
    Contributor

    Has anyone tried to contact JW and ask them if they can't enable cors on their side to fix it?

  5. J0WI commented on Apr 13, 2016

    @J0WI
    Contributor

    Maybe someone official from the EFF could do that (@jsha).
    Mostly the won't care about daily requests.

  6. jsha commented on Apr 14, 2016

    @jsha
    Member

    In general, when rulesets, especially partial rulesets, are broken, I think we should just disable or delete them. In this case it sounds like there's a specific video provider (jwplatform) that is causing a lot of rules to break that used to work. Is that an accurate statement? @Hainish can you take a look?

  7. terrorist96 commented on May 13, 2016

    @terrorist96
    ContributorAuthor

    Still broken in Version: 2016.5.10
    I wish the policy would be to immediately deactivate rules that breaks websites, and only to reactivate them after the issue has been fixed, instead of leaving the rules active (i.e. sites broken) while waiting on a fix.

  8. added a commit that references this issue on May 14, 2016
    d7e3895
  9. added this to the Before the Next Release milestone on May 14, 2016
  10. J0WI commented on May 14, 2016

    @J0WI
    Contributor

    I made an exclusion for the affected xml files in #4787.
    I didn't remove dashboard because it still works and there are some deep links that doesn't redirect.

  11. removed this from the Before the Next Release milestone on May 14, 2016
  12. terrorist96 commented on Jun 10, 2016

    @terrorist96
    ContributorAuthor

    @Hainish @J0WI Still broken in 2016.6.9.

  13. J0WI commented on Jun 10, 2016

    @J0WI
    Contributor

    This has been fixed, your example depends on #4545 which indeed hasn't been fixed yet.

  14. terrorist96 commented on Jun 10, 2016

    @terrorist96
    ContributorAuthor

    Nope. Disabling Google APIs and leaving JW active, the videos are still broken in both links.

  15. J0WI commented on Jun 10, 2016

    @J0WI
    Contributor

    Works for me on Firefox with a clean profile out of the box.

  16. terrorist96 commented on Jun 10, 2016

    @terrorist96
    ContributorAuthor

    And it doesn't work for me on Chrome, in a clean profile, with only HTTPS Everywhere installed.

  17. J0WI commented on Jun 10, 2016

    @J0WI
    Contributor

    Please open a new issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions