Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Add JS syntax checking as part of build process #4039

Closed

Description

@jsha

In both Firefox and Chrome, it can require some digging in debug menus to find basic syntax errors in the extension. We should add a basic syntax checker that runs each time we run chromium.sh or firefox.sh, to catch such problems before even starting the browser.

We have a few options. Closure Compiler is the best in my opinion, and features more powerful correctness checks beyond just syntax. However, it requires developers to have Java installed (and probably has a couple of seconds startup time because of that). Alternately we can use Esprima, which is available as a Node module. Currently we don't have a dev dependency on Node either, but I feel it is more likely that HTTPSE devs will have Node than that they will have Java.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions