You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
https_everywhere_checker disables good rewrites when only from-host times out #2982
Now this might be working as intended but it seems that it's not: the PR #2939 gave an example of a host (banking.spkrb.de) which is being rewritten from HTTP to HTTPS but where the HTTP version actually serves nothing. The checker disabled the ruleset as a result even though it does serve a (perhaps minor) purpose.
Agreed: we already have code that treats connection refuse on an HTTP host as acceptable, we should probably handle timeouts as well. Note that some checker-related bugs are already fixed but still have a backlog of disabled rules checked in that we need to update.
Activity
jsha commentedon Sep 28, 2015
Agreed: we already have code that treats connection refuse on an HTTP host as acceptable, we should probably handle timeouts as well. Note that some checker-related bugs are already fixed but still have a backlog of disabled rules checked in that we need to update.