Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Publish https-everywhere-rewriter #2926

Closed

Description

@RReverser

Would you be open to publishing rewriter to npm? We would like to use it for custom tool testing needs, and would be very convenient not to include it from git submodule just for that.

Activity

  1. RReverser commented on Sep 18, 2015

    @RReverser
    ContributorAuthor

    Ideally would be nice to have ruleSets exposed out-of-module as well.

  2. jsha commented on Sep 28, 2015

    @jsha
    Member

    Yes, I'd definitely be open to that. Would you be interested in being the maintainer for the npm module?

  3. RReverser commented on Sep 28, 2015

    @RReverser
    ContributorAuthor

    Sure, why not.

  4. RReverser commented on Feb 9, 2016

    @RReverser
    ContributorAuthor

    @jsha It looks like rewriter got broken due to restructuring of chromium page and changes to RuleSets constructor, so our code that used it, broke :( (one more reason to keep them as separate packages)

  5. RReverser commented on Feb 9, 2016

    @RReverser
    ContributorAuthor

    @jsha @fuglede On a related note, would you be open to modularizing https-everywhere a bit more? In particular, splitting rules, browser extension and generic code into own submodules so that one could safely update XML data without code breakage and so?

  6. fuglede commented on Feb 9, 2016

    @fuglede
    Contributor

    That idea actually aired in #3999 (comment).

    Personally, I have no strong opinions on the matter; my first thought was that it might make doing projects like https://github.com/chris-barry/darkweb-everywhere a bit more straightforward to maintain, but then again, that's not really a very strong argument for anything.

  7. self-assigned this
    on Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions