You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Would you be open to publishing rewriter to npm? We would like to use it for custom tool testing needs, and would be very convenient not to include it from git submodule just for that.
@jsha It looks like rewriter got broken due to restructuring of chromium page and changes to RuleSets constructor, so our code that used it, broke :( (one more reason to keep them as separate packages)
@jsha@fuglede On a related note, would you be open to modularizing https-everywhere a bit more? In particular, splitting rules, browser extension and generic code into own submodules so that one could safely update XML data without code breakage and so?
Personally, I have no strong opinions on the matter; my first thought was that it might make doing projects like https://github.com/chris-barry/darkweb-everywhere a bit more straightforward to maintain, but then again, that's not really a very strong argument for anything.
Activity
RReverser commentedon Sep 18, 2015
Ideally would be nice to have
ruleSetsexposed out-of-module as well.jsha commentedon Sep 28, 2015
Yes, I'd definitely be open to that. Would you be interested in being the maintainer for the npm module?
RReverser commentedon Sep 28, 2015
Sure, why not.
Ignore node_modules folder in rewriter dir.
RReverser commentedon Feb 9, 2016
@jsha It looks like
rewritergot broken due to restructuring ofchromiumpage and changes toRuleSetsconstructor, so our code that used it, broke :( (one more reason to keep them as separate packages)RReverser commentedon Feb 9, 2016
@jsha @fuglede On a related note, would you be open to modularizing https-everywhere a bit more? In particular, splitting rules, browser extension and generic code into own submodules so that one could safely update XML data without code breakage and so?
fuglede commentedon Feb 9, 2016
That idea actually aired in #3999 (comment).
Personally, I have no strong opinions on the matter; my first thought was that it might make doing projects like https://github.com/chris-barry/darkweb-everywhere a bit more straightforward to maintain, but then again, that's not really a very strong argument for anything.