Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Please disable rule for PrintFriendly #2708

Closed

Description

@j-manu

This is the ruleset - https://github.com/EFForg/https-everywhere/blob/e93105c8ce89f591ceaae1ab7f21ac175ff21bff/src/chrome/content/rules/PrintFriendly.xml

We don't use S3 anymore and haven't used it for a very long time. This particular change broke our product since users with HTTPS anywhere installed received old and invalid code from S3. We had to workaround this by uploading our code to S3 which cannot be a permanent solution.

Activity

  1. jsha commented on Aug 28, 2015

    @jsha
    Member

    Thanks for the report @j-manu, and sorry for breaking your product. Would you like us to disable the whole rule, or just remove the S3 part?

  2. j-manu commented on Aug 29, 2015

    @j-manu
    ContributorAuthor

    Disable the whole rule.

    We don't and can't have HTTPS enabled for the CDN domain as we need to support legacy clients and though we do support HTTPS, the target might change

    HTTPS for our main domain will not work 100% since we embed third party content which may not be HTTPS

    So right now, auto redirecting of HTTP traffic to HTTPS like what https-everywhere does is not an option for us.

  3. J0WI commented on Sep 5, 2015

    @J0WI
    Contributor

    Could you provide a pull request adding default_off="webmaster request"?

  4. j-manu commented on Sep 8, 2015

    @j-manu
    ContributorAuthor

    @J0WI Done. #2821

  5. jsha commented on Sep 28, 2015

    @jsha
    Member

    Fixed, thanks for submitting that pull request @j-manu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions