Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Firefox - turning on Block all HTTP request in incognito mode. #2629

Closed

Description

@direwolfie

Hi! I am running Firefox 40.0 on Ubuntu 14.04 x64.
When I turn on "Block all HTTP requests" in the private window (aka incognito mode) it will enable it in the normal browsing mode, but will not turn the icon red or place a tick mark in the HTTPS-everywhere menu. Hence not showing that Block all HTTP mode is enabled.
It can be reversed by enabling the "Block all HTTP requests" in normal browsing mode or turning on the private browsing window and reversing the setting.
This is very confusing when all http sites refuse to open. Specially since there is no notification that the sites are being blocked by an add-on (like in chrome).
Also, there is the same issue with Show Counter feature.

Hopefully this helps.

Activity

  1. fuglede commented on Aug 21, 2015

    @fuglede
    Contributor

    This is not an answer but rather an initial observation: In the current master, the toolbar button and its label is identified and manipulated through the use of document.getElementById. In the case where one has only two open windows, the toolbar button in the 'other' window can be accessed through window.opener.document.getElementById. That is, one can use that to manipulate both buttons at once. To see how it works, try having the counter label active on both buttons and use the following to manipulate the two labels:

    rsa = document.getElementById("rsapplied");
    rsb = window.opener.document.getElementById("rsapplied");
    rsa.value = 10;
    rsb.value = 60;
    

    Using this trick for detection is clearly a terrible hack though, and it does not appear to extend to the case where there are strictly more than two windows open. This is similar to, but disjoint from, the problems that https://github.com/fuglede/https-everywhere/commit/4d1da58f8163246a5a79220411b2972b1f5d6522 fixed for #2009.

    It would be better to somehow call the UI update methods for all windows at once on change.

  2. gloomy-ghost commented on Sep 1, 2017

    @gloomy-ghost
    Collaborator

    Verified as fixed in the WebExtension version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions