Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

"Block all HTTP requests" blocks requests even to localhost #2323

Closed

Description

@adammw

Localhost refers to the 127.0.0.1 loopback interface, therefore no data is ever leaving the network. Including it in the "block all HTTP requests" makes it needlessly harder to interact with local webservers.

Activity

  1. semenko commented on Dec 17, 2015

    @semenko
    Contributor

    Going to close as wontfix for now.

    Feel free to send a PR to fix, but this adds a fair amount of complexity if we try to deal with localhost 127.0.0.0/8 resolution, etc.

  2. mweitzel commented on Dec 25, 2015

    @mweitzel

    What about an HTTP-OK whitelist? That would resolve this without it being a special case fix.

  3. semenko commented on Dec 27, 2015

    @semenko
    Contributor

    Ok, rethinking this, I like it. I'll try to integrate it, at least in Chrome, with the overhaul of the extension.

    Chrome trusts these origins, which we should whitelist (if we see them in webRequest):

    (https, *, *)
    (wss, *, *)
    (*, localhost, *)
    (*, 127/8, *)
    (*, ::1/128, *)
    (file, *, —)
    (chrome-extension, *, —)
    

    per https://www.chromium.org/Home/chromium-security/security-faq#TOC-Which-origins-are-secure-

  4. self-assigned this
    on Dec 27, 2015
  5. Bisaloo commented on Mar 4, 2017

    @Bisaloo
    Collaborator

    @Hainish, what's the status of this after 1dafcc9?

  6. jeremyn commented on Nov 7, 2017

    @jeremyn
    Contributor

    I've closed issues #9142 and #13511 as duplicates of this issue, though those issues are about allowing unencrypted requests to RFC1918 private addresses and not localhost 127.0.0.1/8. If a fix for this issue is limited to just localhost, then one of those issues should be reopened or a new issue should be created to cover other private address ranges.

  7. Hainish commented on Sep 7, 2018

    @Hainish
    Member

    This is no longer the case, closing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions