Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Vitalwerks.xml no-ip.com suspect regex #18877

Closed

Description

@jayvdb

Type: ruleset/website issue

Domain: no-ip.com

215702b1be added this rule, and it contains regex snippet [^$] which I believe always means 'a char, except literal $'. I assume what was intended was 'not end of URL', which is almost the same thing, however . would have achieved that more simply.

> r = RegExp('a[^$]')
/a[^$]/
> 'aa'.match(r)
[ 'aa', index: 0, input: 'aa' ]
> 'a$'.match(r)
null

Activity

  1. self-assigned this
    on Feb 9, 2020
  2. jayvdb commented on Apr 11, 2020

    @jayvdb
    ContributorAuthor

    (btw, I confirmed that the [^$] is illogical regex here, so I dont think more info is required.)

    https://www.noip.com/company redirects to https://www.noip.com/about

    https://www.noip.com/clients is 404

    newUser is replaced by https://www.noip.com/sign-up

    Basically, this rule is broken.

    And in addition, it has a s3 rule.

    #17912

  3. added a commit that references this issue on Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions