You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Link to downgrade attack explanation on EASE error page is missing from some translations #18702
So after investigating this it appears to be case sensitive replacement and some mishandling of that on our part.
So for example, the German text in the paragraph is: netzwerkbasierte Downgrade-Angriffe but the replacement text to insert the link is looking for Netzwerk-basierte Downgrade Angriffe.
Now that I think I found the issue, will think of a way to handle this better.
@zoracon My guess is real solution could be allowing some BBCode- or Markdown-like syntax in translations, of course with restriction what websites could be linked to. We should probably link to an language-appropriate version of Wikipedia if possible.
Activity
pipboy96 commentedon Nov 25, 2019
cc @zoracon.
zoracon commentedon Dec 10, 2019
So after investigating this it appears to be case sensitive replacement and some mishandling of that on our part.
So for example, the German text in the paragraph is:
netzwerkbasierte Downgrade-Angriffebut the replacement text to insert the link is looking forNetzwerk-basierte Downgrade Angriffe.Now that I think I found the issue, will think of a way to handle this better.
Add conditional if link replace fails
Hotfix: EASE interstitial Link Failing for some Locales (#18737)
pipboy96 commentedon Dec 13, 2019
I hope a real solution will be done shortly.
zoracon commentedon Dec 13, 2019
@pipboy96 for now this is the "real solution". Can you clarify what a better solution would look like?
pipboy96 commentedon Dec 13, 2019
@zoracon My guess is real solution could be allowing some BBCode- or Markdown-like syntax in translations, of course with restriction what websites could be linked to. We should probably link to an language-appropriate version of Wikipedia if possible.