You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
HTTPS-E conflicts with NoScript in Tor Browser at Safest security setting when the EASE mode is enabled #17735
HTTPS-E conflicts with NoScript in Tor Browser at Safest security setting when the EASE mode is enabled. To test this use a mixedcontent website that normally would load under EASE mode with standard security setting. i wonder if it's possible to fix this in some way.
I can reproduce this by using the "Safest" security level and setting EASE mode enabled. However, may I know how do you scope this down to NoScript? I think this could be related to the fact that only 1 extension is allowed to modify the request headers. See #14600 (comment)
To reproduce:
Configure tor browser to use "Safest" security level and turn on EASE mode.
@cschanaj If there is mixed content, green lock never appears, even if it's rewritten, since MCB happens before WebExtensions sees the request (it can appear if all mixed content requests are blocked, for example if all of them are active).
@cschanaj If there is mixed content, green lock never appears, even if it's rewritten, since MCB happens before WebExtensions sees the request (it can appear if all mixed content requests are blocked, for example if all of them are active).
IIRC, this is because we injected the upgrade-insecure-requests CSP to the response headers in EASE mode, the green padlock is shown if all requests are upgraded successfully. In such case, the requests upgrade is performed by the browser/ client, not webextensions.
P.S. I think you can reproduce the expected behavior on Firefox with EASE mode is enabled (with only HTTPSE enabled)
cc @Hainish@zoracon just in case EFF might want to implement any fix or response to this. This bug affect tor browser and if HTTPSE wins NoScript in the header rewrites, it might have certain security implications.
Activity
pipboy96 commentedon Apr 13, 2019
Please give more details about this issue. How does the conflict look like?
cschanaj commentedon Apr 13, 2019
I can reproduce this by using the "Safest" security level and setting EASE mode enabled.
However, may I know how do you scope this down to NoScript?I think this could be related to the fact that only 1 extension is allowed to modify the request headers. See #14600 (comment)To reproduce:
Expect:
The mixed content are upgraded, noticeably the tor browser shows a green padlock on the address bar.
Actual:
Mixed content warning appear.
Ref:
https://tb-manual.torproject.org/security-slider/
pipboy96 commentedon Apr 13, 2019
@cschanaj If there is mixed content, green lock never appears, even if it's rewritten, since MCB happens before WebExtensions sees the request (it can appear if all mixed content requests are blocked, for example if all of them are active).
pipboy96 commentedon Apr 13, 2019
Having different behavior with NS on and off is strange, and should be investigated since we officially support Tor Browser.
cschanaj commentedon Apr 13, 2019
IIRC, this is because we injected the
upgrade-insecure-requestsCSP to the response headers in EASE mode, the green padlock is shown if all requests are upgraded successfully. In such case, the requests upgrade is performed by the browser/ client, not webextensions.P.S. I think you can reproduce the expected behavior on Firefox with EASE mode is enabled (with only HTTPSE enabled)
Possibly related #14961
pipboy96 commentedon Apr 14, 2019
High priority since this affects Tor Browser.
cschanaj commentedon Jun 8, 2019
cc @Hainish @zoracon just in case EFF might want to implement any fix or response to this. This bug affect tor browser and if HTTPSE wins NoScript in the header rewrites, it might have certain security implications.
pipboy96 commentedon Jun 8, 2019
@cschanaj ?
Hainish commentedon Jun 18, 2019
What's strange is that if you look at the network tab with EASE mode and the safest security setting, no HTTP requests are being made.
Hainish commentedon Jun 18, 2019
This is not happening within Firefox with JavaScript completely disabled. I've notified Tor Browser developers of this strange behavior.