Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

HTTPS-E conflicts with NoScript in Tor Browser at Safest security setting when the EASE mode is enabled #17735

Closed

Description

@Giltyhub

Type: code issue

HTTPS-E conflicts with NoScript in Tor Browser at Safest security setting when the EASE mode is enabled. To test this use a mixedcontent website that normally would load under EASE mode with standard security setting. i wonder if it's possible to fix this in some way.

Activity

  1. pipboy96 commented on Apr 13, 2019

    @pipboy96
    Contributor

    Please give more details about this issue. How does the conflict look like?

  2. cschanaj commented on Apr 13, 2019

    @cschanaj
    Collaborator

    I can reproduce this by using the "Safest" security level and setting EASE mode enabled. However, may I know how do you scope this down to NoScript? I think this could be related to the fact that only 1 extension is allowed to modify the request headers. See #14600 (comment)

    To reproduce:

    1. Configure tor browser to use "Safest" security level and turn on EASE mode.
    2. Visit https://mixed.badssl.com/

    Expect:

    The mixed content are upgraded, noticeably the tor browser shows a green padlock on the address bar.

    Actual:

    Mixed content warning appear.

    Ref:

    https://tb-manual.torproject.org/security-slider/

  3. pipboy96 commented on Apr 13, 2019

    @pipboy96
    Contributor

    @cschanaj If there is mixed content, green lock never appears, even if it's rewritten, since MCB happens before WebExtensions sees the request (it can appear if all mixed content requests are blocked, for example if all of them are active).

  4. pipboy96 commented on Apr 13, 2019

    @pipboy96
    Contributor

    Having different behavior with NS on and off is strange, and should be investigated since we officially support Tor Browser.

  5. self-assigned this
    on Apr 13, 2019
  6. cschanaj commented on Apr 13, 2019

    @cschanaj
    Collaborator

    @cschanaj If there is mixed content, green lock never appears, even if it's rewritten, since MCB happens before WebExtensions sees the request (it can appear if all mixed content requests are blocked, for example if all of them are active).

    IIRC, this is because we injected the upgrade-insecure-requests CSP to the response headers in EASE mode, the green padlock is shown if all requests are upgraded successfully. In such case, the requests upgrade is performed by the browser/ client, not webextensions.

    P.S. I think you can reproduce the expected behavior on Firefox with EASE mode is enabled (with only HTTPSE enabled)

    Possibly related #14961

  7. pipboy96 commented on Apr 14, 2019

    @pipboy96
    Contributor

    High priority since this affects Tor Browser.

  8. cschanaj commented on Jun 8, 2019

    @cschanaj
    Collaborator

    cc @Hainish @zoracon just in case EFF might want to implement any fix or response to this. This bug affect tor browser and if HTTPSE wins NoScript in the header rewrites, it might have certain security implications.

  9. pipboy96 commented on Jun 8, 2019

    @pipboy96
    Contributor
  10. added
    EFFSomeone at EFF needs to look into
    on Jun 9, 2019
  11. Hainish commented on Jun 18, 2019

    @Hainish
    Member

    What's strange is that if you look at the network tab with EASE mode and the safest security setting, no HTTP requests are being made.

  12. Hainish commented on Jun 18, 2019

    @Hainish
    Member

    This is not happening within Firefox with JavaScript completely disabled. I've notified Tor Browser developers of this strange behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions