Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Mismatch between hsts-prune and hstspreload.org minimal max-age #17506

Closed

Description

@Bisaloo

Type: other

The minimal max-age for preloading eligibility via https://hstspreload.org increased to 1 year (chromium/hstspreload.org@b48ae5a). Yet, our hsts-prune script still uses the old requirement of 18 weeks:

preload && include_subdomains && max_age >= 10886400);

Is it something we should change?

Activity

  1. pipboy96 commented on Feb 23, 2019

    @pipboy96
    Contributor

    My guess is that we should follow the actual browser preload lists, not the policies for new entries, e.g. if website was previously added with less than 1 year max-age, we should keep it.

  2. cschanaj commented on Feb 23, 2019

    @cschanaj
    Collaborator

    From chromium/hstspreload.org@b48ae5a

    ... and that sites may be removed automatically in the future for failing to keep up the requirements.

    IMHO, we should follow the hstspreload.org minimal max-age policy and increase the requirement. Otherwise, the script might mistakenly remove rulesets for sites that are in a pending removal status from the preload list.

  3. pipboy96 commented on Feb 23, 2019

    @pipboy96
    Contributor

    @cschanaj I think there is an API to check if website is pending removal.
    EDIT: Indeed there is one: https://hstspreload.org/api/v2/preloadable?domain=eff.org

  4. cschanaj commented on Feb 23, 2019

    @cschanaj
    Collaborator

    @pipboy96 yes, there is an API https://hstspreload.org/api/v2/pending-removal to retrieve a list of pending removal domains. (However, for how long an entry will be kept in this list???)

    AFAIK, hsts-prune works by comparing the inclusion of the preload lists bundled to our supported browsers' source code, which the updates might lag behind hstspreload.org (a). It increases the likelihood to mistakenly remove a targets from our rulesets if we use a looser policy.

    hsts-prune will normally check if a target is included in all preload lists bundled in the supported browsers AND then send a request to check the HSTS header. A target for a site will only be removed if it is preloaded in all supported browsers and

    preload && include_subdomains && max_age >= 10886400);

    hold true. We should use a stricter policy (max-age > 1 year) to avoid leaving sites unprotected. It also do less harm even if (a) is not the case.

  5. pipboy96 commented on Feb 23, 2019

    @pipboy96
    Contributor

    Closed by #17507.

  6. added a commit that references this issue on Feb 27, 2019
    3d8aaaf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions