You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Mismatch between hsts-prune and hstspreload.org minimal max-age #17506
My guess is that we should follow the actual browser preload lists, not the policies for new entries, e.g. if website was previously added with less than 1 year max-age, we should keep it.
... and that sites may be removed automatically in the future for failing to keep up the requirements.
IMHO, we should follow the hstspreload.org minimal max-age policy and increase the requirement. Otherwise, the script might mistakenly remove rulesets for sites that are in a pending removal status from the preload list.
AFAIK, hsts-prune works by comparing the inclusion of the preload lists bundled to our supported browsers' source code, which the updates might lag behind hstspreload.org (a). It increases the likelihood to mistakenly remove a targets from our rulesets if we use a looser policy.
hsts-prune will normally check if a target is included in all preload lists bundled in the supported browsers AND then send a request to check the HSTS header. A target for a site will only be removed if it is preloaded in all supported browsers and
Activity
pipboy96 commentedon Feb 23, 2019
My guess is that we should follow the actual browser preload lists, not the policies for new entries, e.g. if website was previously added with less than 1 year
max-age, we should keep it.cschanaj commentedon Feb 23, 2019
From chromium/hstspreload.org@b48ae5a
IMHO, we should follow the hstspreload.org minimal max-age policy and increase the requirement. Otherwise, the script might mistakenly remove rulesets for sites that are in a pending removal status from the preload list.
pipboy96 commentedon Feb 23, 2019
@cschanaj I think there is an API to check if website is pending removal.
EDIT: Indeed there is one: https://hstspreload.org/api/v2/preloadable?domain=eff.org
cschanaj commentedon Feb 23, 2019
@pipboy96 yes, there is an API https://hstspreload.org/api/v2/pending-removal to retrieve a list of pending removal domains. (However, for how long an entry will be kept in this list???)
AFAIK,
hsts-pruneworks by comparing the inclusion of the preload lists bundled to our supported browsers' source code, which the updates might lag behind hstspreload.org (a). It increases the likelihood to mistakenly remove a targets from our rulesets if we use a looser policy.hsts-prunewill normally check if a target is included in all preload lists bundled in the supported browsers AND then send a request to check the HSTS header. A target for a site will only be removed if it is preloaded in all supported browsers andhttps-everywhere/utils/hsts-prune/index.js
Line 148 in 3895957
hold true. We should use a stricter policy (
max-age > 1 year) to avoid leaving sites unprotected. It also do less harm even if (a) is not the case.pipboy96 commentedon Feb 23, 2019
Closed by #17507.
Reflect the change in HSTS preload rules. (#17507)