You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Lenovo unable to customize computers or see "Sold Out" when enabled in https-everywhere #1656
Did it get worse? The links referenced above now show a blank page. Other links like this one [http://shop.lenovo.com/us/en/smartphones/phab-series/phab2/] look very broken. They're all fixed if HTTPS Everywhere is disabled.
Looks like the problem is that even though lenovo.com supports https there is a single request that is not getting blocked but returning a 509 "bandwidth exceeded" error code when made with https. When I make the request over http it returns a larg(-ish) response body. I'm guessing lenovo has configured their servers to refuse to serve large requests over https. Is it possible to add a rule that will retry a request with http when it gets a 509 error code?
There's a lot in the Lenovo rule, but it looks like only the shop.lenovo.com subdomain has been having problems. I think disabling that target and the associated rules, exceptions, and tests should do fix this.
If a whole lot of extra work is required when this ruleset is modified due to the file hash no longer matching the whitelists, I think it's fine to re-whitelist rather than fix a bunch of unrelated problems
Activity
reedy commentedon Jun 3, 2015
Confirmed
pde commentedon Mar 29, 2016
Ugh, I just encountered this. If we can't get a fix, we should disable the ruleset by default :(. CC: @Hainish @loveithateit
Remove 'shop' subdomain from Lenovo targets, tests, exclusions (resolves
Remove 'shop' subdomain from Lenovo targets, tests, exclusions (resolves
Remove 'shop' subdomain from Lenovo targets, tests, exclusions (resolves
KommX commentedon May 25, 2016
This bug is still present.
Test case:
http://shop.lenovo.com/us/en/laptops/thinkpad/t-series/t460s/
Fix EFForg#1656
Fix EFForg#1656
Hainish commentedon Jun 3, 2016
@galeksandrp are you working on a full review of this ruleset? If not, I think we should disable/delete it.
Fix EFForg#1656
Fix EFForg#1656
Fix EFForg#1656
coman4 commentedon Nov 1, 2016
Did it get worse? The links referenced above now show a blank page. Other links like this one [http://shop.lenovo.com/us/en/smartphones/phab-series/phab2/] look very broken. They're all fixed if HTTPS Everywhere is disabled.
jwarkentin commentedon Mar 29, 2017
Still very broken. It took me a while to figure out which extension was breaking things.
Example: http://shop.lenovo.com/us/en/laptops/thinkpad/t-series/t570
jwarkentin commentedon Mar 29, 2017
Looks like the problem is that even though lenovo.com supports https there is a single request that is not getting blocked but returning a 509 "bandwidth exceeded" error code when made with https. When I make the request over http it returns a larg(-ish) response body. I'm guessing lenovo has configured their servers to refuse to serve large requests over https. Is it possible to add a rule that will retry a request with http when it gets a 509 error code?
Hainish commentedon Mar 29, 2017
There's a lot in the Lenovo rule, but it looks like only the
shop.lenovo.comsubdomain has been having problems. I think disabling thattargetand the associatedrules,exceptions, andtestsshould do fix this.Hainish commentedon Mar 29, 2017
If a whole lot of extra work is required when this ruleset is modified due to the file hash no longer matching the whitelists, I think it's fine to re-whitelist rather than fix a bunch of unrelated problems
J0WI commentedon Apr 10, 2017
Closed by #9381