Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Lenovo unable to customize computers or see "Sold Out" when enabled in https-everywhere #1656

Closed

Description

@jcosentino

Eg:
http://shop.lenovo.com/us/en/laptops/thinkpad/x-series/x1-carbon/

Fixed by disabling Lenovo in https-everywhere

Activity

  1. reedy commented on Jun 3, 2015

    @reedy
    Contributor

    Confirmed

  2. pde commented on Mar 29, 2016

    @pde
    Contributor

    Ugh, I just encountered this. If we can't get a fix, we should disable the ruleset by default :(. CC: @Hainish @loveithateit

  3. added 3 commits that reference this issue on May 12, 2016
    0b38069
    5daedd8
    19550a1
  4. KommX commented on May 25, 2016

    @KommX
    Contributor
  5. added 2 commits that reference this issue on May 29, 2016
    f13cdd6
    06875db
  6. Hainish commented on Jun 3, 2016

    @Hainish
    Member

    @galeksandrp are you working on a full review of this ruleset? If not, I think we should disable/delete it.

  7. added 3 commits that reference this issue on Jul 29, 2016
    54c129b
    fe2a781
    067cb66
  8. coman4 commented on Nov 1, 2016

    @coman4

    Did it get worse? The links referenced above now show a blank page. Other links like this one [http://shop.lenovo.com/us/en/smartphones/phab-series/phab2/] look very broken. They're all fixed if HTTPS Everywhere is disabled.

  9. jwarkentin commented on Mar 29, 2017

    @jwarkentin

    Still very broken. It took me a while to figure out which extension was breaking things.

    Example: http://shop.lenovo.com/us/en/laptops/thinkpad/t-series/t570

  10. jwarkentin commented on Mar 29, 2017

    @jwarkentin

    Looks like the problem is that even though lenovo.com supports https there is a single request that is not getting blocked but returning a 509 "bandwidth exceeded" error code when made with https. When I make the request over http it returns a larg(-ish) response body. I'm guessing lenovo has configured their servers to refuse to serve large requests over https. Is it possible to add a rule that will retry a request with http when it gets a 509 error code?

  11. Hainish commented on Mar 29, 2017

    @Hainish
    Member

    There's a lot in the Lenovo rule, but it looks like only the shop.lenovo.com subdomain has been having problems. I think disabling that target and the associated rules, exceptions, and tests should do fix this.

  12. Hainish commented on Mar 29, 2017

    @Hainish
    Member

    If a whole lot of extra work is required when this ruleset is modified due to the file hash no longer matching the whitelists, I think it's fine to re-whitelist rather than fix a bunch of unrelated problems

  13. J0WI commented on Apr 10, 2017

    @J0WI
    Contributor

    Closed by #9381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions