You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Validations test not reliably catching duplicate targets #16468
The validations test for this build passed, even though a target (<target host="s.wsj.net" />) was included twice in the same ruleset.
However, the same duplicate-target mistake caused the build before that to fail the validations test.
I am able to reproduce this issue when I created #18781 with an outdated branch on my fork. I tried to add coverage to lbpics.ust.hk without realizing that it was already done in ee97815 . When Travis run the validations, my PR is merged to the master gracefully (yet unfortunately) without merge conflicts. This resulted in 2 occurences of lbpics.ust.hk in the merged branch, and thus the failing validations test.
While this is not a bug, a clearer debug message on Travis is most welcomed.
Activity
cschanaj commentedon Jan 3, 2020
I am able to reproduce this issue when I created #18781 with an outdated branch on my fork. I tried to add coverage to
lbpics.ust.hkwithout realizing that it was already done in ee97815 . When Travis run the validations, my PR is merged to themastergracefully (yet unfortunately) without merge conflicts. This resulted in 2 occurences oflbpics.ust.hkin the merged branch, and thus the failingvalidationstest.While this is not a bug, a clearer debug message on Travis is most welcomed.
cc @zoracon @Bisaloo @J0WI @pipboy96