Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Validations test not reliably catching duplicate targets #16468

Closed

Description

@injust

Type: code issue

The validations test for this build passed, even though a target (<target host="s.wsj.net" />) was included twice in the same ruleset.
However, the same duplicate-target mistake caused the build before that to fail the validations test.

Activity

  1. cschanaj commented on Jan 3, 2020

    @cschanaj
    Collaborator

    I am able to reproduce this issue when I created #18781 with an outdated branch on my fork. I tried to add coverage to lbpics.ust.hk without realizing that it was already done in ee97815 . When Travis run the validations, my PR is merged to the master gracefully (yet unfortunately) without merge conflicts. This resulted in 2 occurences of lbpics.ust.hk in the merged branch, and thus the failing validations test.

    While this is not a bug, a clearer debug message on Travis is most welcomed.

    cc @zoracon @Bisaloo @J0WI @pipboy96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions