You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
New "HTTPS unavailable" interstitial page misses some cases #16418
I've got the latest HTTPS Everywhere, and tested http://http.badssl.com/ with "Block All HTTP Requests" enabled; the interstitial works great!
However, when I visit http://brokenballots.com, I get the browser's "Connection timed out" error.
Disabling "Block all HTTP Requests" allows me to visit the site (which is a redirect).
I tried to fix this with chrome.tab.update to force redirect a tab to the interstitial page, but it could not distinguish errors which are not caused by HTTPSE, e.g. Could not resolve host. So I guess a more sophisticated mechanism is needed to fix this.
Yeah, this is tricky. It'll be hard to know whether any given error was the result of HTTPS Everywhere's rewrite instead of a regular host problem. Should we try listing out the errors that are probably a result of HTTPSE?
string. The error description. This string is an internal error string, may vary from one browser to another, and is not guaranteed to stay the same between releases.
This might require some maintenance effort, since the strings might change from time to time according to Mozilla's documentation. However, I think this is a good workaround for SSL errors which hopefully the messages will not change frequently.
For Firefox, this is very tricky. I received these three errors in details.error for three different HTTPS bad configurations:
NS_ERROR_CONNECTION_REFUSED SSL received a record that exceeded the maximum permissible length. NS_ERROR_UNKNOWN_HOST
I could enumerate these but it seems like a maintenance nightmare, especially if there is no guarantee that they'll be constant from one version to the next.
I've fixed this for Chrome, anyway: Hainish@ef50c39. This limits the interstitial page to showing only when HTTP Nowhere has done an explicit redirect to HTTPS.
One solution for Firefox that seems really ugly is just ignoring the error code and if an HTTP Nowhere HTTPS redirect is issued, show the interstitial page. Of course, this will mean that DNS resolution failures will result in the interstitial page too. I don't think that the trade-off is worth it in this case.
I've added more SSL misconfigurations to this list: Hainish@dafe0c1
Chrome makes you pause on the browser error page before redirecting you to HTTPS Everywhere's interstitial, for some reason. Probably for security reasons. But then when you click back, forward, or reload it shows you the HTTPS Everywhere page.
Activity
bcyphers commentedon Aug 28, 2018
Related to #16394?
cschanaj commentedon Aug 29, 2018
AFAIK, this is not related to #16394. These errors happen when the requests are already made and should be handled in
onErrorOccurred(details).https-everywhere/chromium/background-scripts/background.js
Lines 586 to 590 in ca0db7b
I tried to fix this with
chrome.tab.updateto force redirect a tab to the interstitial page, but it could not distinguish errors which are not caused by HTTPSE, e.g.Could not resolve host. So I guess a more sophisticated mechanism is needed to fix this.bcyphers commentedon Aug 29, 2018
Yeah, this is tricky. It'll be hard to know whether any given error was the result of HTTPS Everywhere's rewrite instead of a regular host problem. Should we try listing out the errors that are probably a result of HTTPSE?
cschanaj commentedon Aug 30, 2018
This might require some maintenance effort, since the strings might change from time to time according to Mozilla's documentation. However, I think this is a good workaround for SSL errors which hopefully the messages will not change frequently.
Hainish commentedon Sep 13, 2018
In Chrome I can enumerate a class of errors that are likely due to HTTPS misconfigurations:
For Firefox, this is very tricky. I received these three errors in
details.errorfor three different HTTPS bad configurations:NS_ERROR_CONNECTION_REFUSEDSSL received a record that exceeded the maximum permissible length.NS_ERROR_UNKNOWN_HOSTI could enumerate these but it seems like a maintenance nightmare, especially if there is no guarantee that they'll be constant from one version to the next.
I've fixed this for Chrome, anyway: Hainish@ef50c39. This limits the interstitial page to showing only when HTTP Nowhere has done an explicit redirect to HTTPS.
One solution for Firefox that seems really ugly is just ignoring the error code and if an HTTP Nowhere HTTPS redirect is issued, show the interstitial page. Of course, this will mean that DNS resolution failures will result in the interstitial page too. I don't think that the trade-off is worth it in this case.
Hainish commentedon Sep 14, 2018
I've added more SSL misconfigurations to this list: Hainish@dafe0c1
Chrome makes you pause on the browser error page before redirecting you to HTTPS Everywhere's interstitial, for some reason. Probably for security reasons. But then when you click back, forward, or reload it shows you the HTTPS Everywhere page.
So this seems ready to go in https://github.com/Hainish/https-everywhere/tree/disable-per-site
Hainish commentedon Sep 18, 2018
Implemented in #16546