You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
cookie changed to "secure" even if connection was NOT https #1584
Thanks for improving the ruleset... but it's not what my bug report was about. Honestly I think the original ruleset didn't really have a problem; the problem is with the fact that https-everywhere changes the cookie to "secure" even if it was not sent over a secure connection. Not only is that in contradiction of the docs, it also makes no sense; a cookie set by a http://whatever.com will never be sent back on future visits to http://whatever.com if it's marked secure; it's completely useless.
This is a bug with https-everywhere, not with this specific rule.
More specifically, a few of our subdomains do not support HTTPS. For example http://www.d.animenewsnetwork.com/ is meant to bypass Cloudflare (because sometimes it's wonky) and therefore doesn't have HTTPS. But the session cookie is still set with domain=.animenewsnetwork.com and therefore is converted to "secure". Which makes it impossible to be logged in at that url.
I very much appreciate the fact that Anime News Network has been added to https-everywhere. An easy fix would be to remove the <securecookie> tag in this ruleset, but the real fix is to set the secure flag only for cookies sent over a HTTPS connection.
Even though the login "works" (no error message), you will not be logged in because the session cookie is flagged as secure even though the url is not HTTPS.
Also, I'm having trouble signing up for an account (email hasn't arrived yet). If you can send me a test login (jsha@eff.org) that would be very helpful.
Activity
dan42 commentedon Apr 26, 2015
Thanks for improving the ruleset... but it's not what my bug report was about. Honestly I think the original ruleset didn't really have a problem; the problem is with the fact that https-everywhere changes the cookie to "secure" even if it was not sent over a secure connection. Not only is that in contradiction of the docs, it also makes no sense; a cookie set by a http://whatever.com will never be sent back on future visits to http://whatever.com if it's marked secure; it's completely useless.
This is a bug with https-everywhere, not with this specific rule.
More specifically, a few of our subdomains do not support HTTPS. For example http://www.d.animenewsnetwork.com/ is meant to bypass Cloudflare (because sometimes it's wonky) and therefore doesn't have HTTPS. But the session cookie is still set with domain=.animenewsnetwork.com and therefore is converted to "secure". Which makes it impossible to be logged in at that url.
I very much appreciate the fact that Anime News Network has been added to https-everywhere. An easy fix would be to remove the <securecookie> tag in this ruleset, but the real fix is to set the secure flag only for cookies sent over a HTTPS connection.
dan42 commentedon Apr 27, 2015
It's worth noting this is a problem with both the Firefox ands Chrome plugins.
jsha commentedon Apr 27, 2015
@dan42: I wasn't able to reproduce on Firefox. Can you provide detailed repro instructions?
dan42 commentedon Apr 27, 2015
Even though the login "works" (no error message), you will not be logged in because the session cookie is flagged as secure even though the url is not HTTPS.
jsha commentedon Apr 27, 2015
Which cookie is the one you find is marked secure?
dan42 commentedon Apr 27, 2015
ann5_session_id
jsha commentedon Apr 27, 2015
Also, I'm having trouble signing up for an account (email hasn't arrived yet). If you can send me a test login (jsha@eff.org) that would be very helpful.
dan42 commentedon Apr 27, 2015
Ok I sent you a test account
jsha commentedon Apr 27, 2015
Great, thanks! I can reproduce now. I'll look into it.
dan42 commentedon Apr 30, 2015
If this bug cannot be resolved in time for the next release, please remove the <securecookie> tag in this ruleset. Thank you.
jsha commentedon Apr 30, 2015
Sounds good. I still want to try and figure out why HTTPS Everywhere is securing a cookie sent over HTTP, but I've merged @Deathlyx's change.
gloomy-ghost commentedon Nov 23, 2016
Does 0fcd111 resolve the issue?