Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Test if test url is covered by any target #14290

Closed

Description

@J0WI

Test urls with hosts not related to any target are currently allowed in rulesets.
The following scenario should should fail in ruleset tests:

<ruleset name="example">
	<target host="target.example" />

	<test url="http://no-target.example/" />

	<rule from="^http:" to="https:" />
</ruleset>

Type: other

Activity

  1. jeremyn commented on Jan 14, 2018

    @jeremyn
    Contributor

    This might be challenging to check completely, for example for a wildcard target with a very complex rule.

    Have you seen rulesets like this in the wild?

  2. J0WI commented on Jan 14, 2018

    @J0WI
    ContributorAuthor

    One example has been fixed here: #14177

  3. cschanaj commented on Jan 15, 2018

    @cschanaj
    Collaborator

    Submitted a PR in #14293 (not really sure if I have the implementation correct.. though)

    @Hainish there is something wrong with Travis chrome-beta and chrome-stable since d36ea40. Would you mind to take a look?

  4. Hainish commented on Jan 16, 2018

    @Hainish
    Member

    @cschanaj looking now

  5. Hainish commented on Jan 17, 2018

    @Hainish
    Member

    @cschanaj this should be fixed with 7f4fe7c, thanks for alerting me to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions