Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

List all conflicting filenames due to case-insensitivity issues #1401

Closed

Description

@reedy

Sometimes when I'm being "lazy", I work directly from github.com. And as it doesn't like all the files in the rules folder, you can't view them easily.

Merging #1159 broke the build, so I deleted said file when I noticed. However, it doesn't tell you what the names of the conflicting files actually are

Generating sqlite DB
src/chrome/content/rules/geocaching.com.xml failed case-insensitivity testing.
Rules exist with identical case-insensitive names, which breaks some filesystems.

Can we have it spit out all the conflicts in https://github.com/EFForg/https-everywhere/blob/master/utils/make-sqlite.py#L54 ?

Activity

  1. reedy commented on Apr 10, 2015

    @reedy
    ContributorAuthor

    (another reason having things rebased before merging would be nice)

  2. jsha commented on Apr 10, 2015

    @jsha
    Member

    Yep, spitting out conflicts sounds like a great idea!

    I'm not sure how rebasing would have helped, though?

  3. reedy commented on Apr 11, 2015

    @reedy
    ContributorAuthor

    Forcing the unit tests to be re-run, rather than displaying a potentially old/cached/out of date test run.

    My working example is at Wikimedia for MediaWiki et al, generally we rebase (via one click in gerrit) before merging, which forces one set of test runs, but then on merging, they go through the CI workflow (again), to make sure the tests all pass before actually being merged into the branch. Or, just comment "recheck" has a similar result.

    It's just more because you have to go out of your way to re-run the tests via github, or like I did with this case, notice the failure popping up elsewhere. Which I was then able to quickly resolve.

    No big deal though :)

  4. jsha commented on Apr 13, 2015

    @jsha
    Member

    That sounds great, and easy with gerrit. Do you know of any way to make it that easy with github?

  5. reedy commented on Apr 13, 2015

    @reedy
    ContributorAuthor

    Nope, I'll try having a look around. I can't imagine this would be the first project on github that would want to force a test run before the merge actually being done, even more so with potentially "stale" pull requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions