You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Delete ruleset preferences that are the default #1394
Right now if a user disables, then re-enables a ruleset, we store a preference that that ruleset is enabled, meaning it stays enabled even if we disabled the ruleset by default due to brokenness.
Instead, we should only store preferences that differ from the default value for that ruleset at the time that the preference is altered.
We shouldn't update preferences based on changed in the default state of a ruleset, though, because a ruleset that becomes disabled and then re-enabled by default in subsequent versions could remove somebody's preference that disabled that ruleset.
@J0WI many of these options will linger in the profile once the extension is updated to WebExtensions. At that point, though, they can be safely deleted. The export functionality in #10007 will not include ruleset toggles that are the default.
Activity
J0WI commentedon Jul 14, 2015
+1
My prefs.js is 90% full of HTTPS-Everywhere stuff. I've to clean it up manually.
Hainish commentedon Aug 2, 2017
@J0WI many of these options will linger in the profile once the extension is updated to WebExtensions. At that point, though, they can be safely deleted. The export functionality in #10007 will not include ruleset toggles that are the default.
pipboy96 commentedon Mar 28, 2019
HTTPS Everywhere migrated to WebExtensions.