Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Delete ruleset preferences that are the default #1394

Closed

Description

@jsha

Right now if a user disables, then re-enables a ruleset, we store a preference that that ruleset is enabled, meaning it stays enabled even if we disabled the ruleset by default due to brokenness.

Instead, we should only store preferences that differ from the default value for that ruleset at the time that the preference is altered.

We shouldn't update preferences based on changed in the default state of a ruleset, though, because a ruleset that becomes disabled and then re-enabled by default in subsequent versions could remove somebody's preference that disabled that ruleset.

Activity

  1. J0WI commented on Jul 14, 2015

    @J0WI
    Contributor

    +1
    My prefs.js is 90% full of HTTPS-Everywhere stuff. I've to clean it up manually.

  2. Hainish commented on Aug 2, 2017

    @Hainish
    Member

    @J0WI many of these options will linger in the profile once the extension is updated to WebExtensions. At that point, though, they can be safely deleted. The export functionality in #10007 will not include ruleset toggles that are the default.

  3. pipboy96 commented on Mar 28, 2019

    @pipboy96
    Contributor

    HTTPS Everywhere migrated to WebExtensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions