Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Provide dynamic loading of rulesets to allow update without browser restart #1346

Closed

Description

@timmc

This would be similar to how Adblock Plus filtersets are updated automatically (unless the feature is disabled.)

That said, I wouldn't want this feature unless ruleset updating was at least as secure as updating the extension itself; an attacker who can hijack the ruleset updater can inject arbitrary JS into a user's session by offering their own redirects to malicious sites.

Activity

  1. reedy commented on Apr 10, 2015

    @reedy
    Contributor

    This sounds a lot like #437, and partially #1293

  2. timmc commented on Apr 10, 2015

    @timmc
    Author

    Yes, #437 would resolve this! I only checked issues and forgot to look at PRs.

    I'm not sure exactly what #1293 is; it seems to be about loading stuff from the filesystem.

  3. reedy commented on Apr 11, 2015

    @reedy
    Contributor

    Should we close this as a dupe?

  4. timmc commented on Apr 11, 2015

    @timmc
    Author

    Hmm... I think leave it open until the PR is completed and merged. (If #437 languishes forever or is rejected, I want this issue to stay open.)

    I think #1293 is only about user rules, not the centrally provided ones.

  5. J0WI commented on May 22, 2017

    @J0WI
    Contributor

    Since we have to move to WebextensionAPIs this is done anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions